color correction - PHP

[mcanepa]

I've noticed some php inconsistencies between this theme and atom's. Here is a sample image

[Binaryify]

I don't think it's necessary to modify it. It could be two styles
But the begin I think can be red

[mcanepa]

I agree that it could be two styles. Not necessarily the same color by color

Do you think you could also change the namespace part?

[Binaryify]

@mcanepa yes
how about this

[mcanepa]

much much better! thank you

[Binaryify]

already release~

[andrerahardjo97]

Php end tag is not styled properly. Is this only on my machine? 🤔
If yes, is there is a json setting to force the change of the end tag color?
Thanks in advance, and sorry if my english is bad.

[JordanPak]

@andrerahardjo97 Same issue here G

[machadomatt]

Same issue as @andrerahardjo97. I just did a quick change to "fix it" temporally for now, changing to previous color:

"editor.tokenColorCustomizations": {
    "[One Dark Pro]": {
        "textMateRules": [{
            "scope": ["punctuation.section.embedded.begin.php"],
            "settings": {
                "foreground": "#d55fde"
            }
        }]
    }
},

[JordanPak]

Ah @machadomatt I think that's the "vivid" foreground color. #c678dd should work for the default/non-vivid if that's what you use @andrerahardjo97.

[JordanPak]

Also idk if this was intended so please ignore if so, but the namespace highlighting when instantiating an object looks different now too:

It's still all yellow when declaring the namespace and with use:

[mcanepa]

@JordanPak the namespace change was in fact intended, and both the "declaration" and the "use" are now just like Atom's

[Binaryify]

@JordanPak
that is atom look like

if you don't like it, you can add this in your setting.json

"editor.tokenColorCustomizations": {
    "[One Dark Pro]": {
      "textMateRules": [
        {
          "name": "support.other.namespace.php",
          "scope": [
            "support.other.namespace.php"
          ],
          "settings": {
            "foreground": "#E5C07B"
          }
        }
      ]
    }
  },

[JordanPak]

Ah ok @mcanepa @Binaryify; thanks for clarifying. I like it.

[andrewhawkes]

The <?php and ?> being different colours has really been throwing me off.
Is there any way I can change this back to how it was previously?

[Binaryify]

@andrewhawkes
v3.10.13 should already fixed the different color error
if you want change the color to before
you can add this in your setting.json

  "editor.tokenColorCustomizations": {
    "[One Dark Pro]": {
      "textMateRules": [
        {
          "name": "punctuation.section.embedded.begin.php",
          "scope": [
            "punctuation.section.embedded.begin.php",
            "punctuation.section.embedded.end.php"
          ],
          "settings": {
            "foreground": "#c678dd"  // or #e06c75
          }
        }
      ]
    }
  },

[JordanPak]

Hey @Binaryify thanks for the quick end tag patch and maintaining this awesome theme. Much appreciated!

[Binaryify]

@JordanPak It was careless of me

[andrewhawkes]

@Binaryify thank you that's great!