Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the stripe is too bright #670

Closed
kidsamort opened this issue Jan 1, 2022 · 12 comments
Closed

the stripe is too bright #670

kidsamort opened this issue Jan 1, 2022 · 12 comments
Labels
feature request WIP Work In Process

Comments

@kidsamort
Copy link

I use the one dark pro flat theme precisely because it has minimal borders, but since the recent update, the terminal window has changed and I've been waiting for half a year, it constantly distracts me, could you tell me how to make the bright stripe I marked less noticeable and disturbing like the others
image

@Binaryify Binaryify added the WIP Work In Process label Jan 1, 2022
@Binaryify
Copy link
Owner

Binaryify commented Jan 1, 2022

you can add this in your setting.json before I release next version

"workbench.colorCustomizations": {
    "terminal.border": "#21252b"
  },

and it will look like this
image

Binaryify added a commit that referenced this issue Jan 2, 2022
@Binaryify
Copy link
Owner

you can check v3.13.9 now~

@kidsamort
Copy link
Author

вы можете проверить v3.13.9 сейчас ~

thanks for such a quick revision, happy new year))

@njbbaer
Copy link

njbbaer commented Jan 4, 2022

@Binaryify I'd like you to reconsider the new color you chose for this. I'm a user of OneDark Pro Darker and it's almost impossible for me to see where one terminal begins and another ends when stacked vertically. For now I've overridden it in my own settings.

I agree the old border stood out too much, but the new one shouldn't be quite so dark. I suggest it matches panel.border which I think is #3e4452

@Binaryify
Copy link
Owner

Binaryify commented Jan 4, 2022

@njbbaer you mean set terminal.border to #3e4452 or panel.border to #3e4452 or both
I think both is fine
and it look like this
image
what do you think @kidsamort

@kidsamort
Copy link
Author

kidsamort commented Jan 4, 2022

"workbench.colorCustomizations": {
"terminal.border": "#21252b"
},
I'll probably stay with these settings because I don't need light border , I already know ui ide so i use "one dark pro flat"
the only thing I need (border) them for is to change sizes @Binaryify

@kidsamort
Copy link
Author

image
maybe I'm used to it, but for me it's intuitively clear where it ends

@Binaryify
Copy link
Owner

Binaryify commented Jan 4, 2022

maybe should let user custom it, it's hard to have consensus
@njbbaer @kidsamort

@kidsamort
Copy link
Author

maybe should let user custom it, it's hard to have consensus @njbbaer @kidsamort

do what that guy wants I think it will be better for everyone and I will stay with the settings

@njbbaer
Copy link

njbbaer commented Jan 5, 2022

@kidsamort The terminals are easier to distinguish when placed horizontally like that, but hard to see when stacked vertically.

Screenshot from 2022-01-04 17-50-13

@Binaryify This is what I have in my settings. I set terminal.border to match panel.border which is much clearer to my eyes.

"workbench.colorCustomizations": {
    "terminal.border": "#3e4452"
},

Obviously if you don't decide to change it I'll just keep these custom settings. But I assume anyone who stacks their terminals vertically like I do would want the border to stand out, at least a little bit.

Screenshot from 2022-01-04 17-52-54

@Binaryify
Copy link
Owner

consider set terminal.border and panel.border to "#3e4452"
what do you think
@kidsamort @njbbaer

@njbbaer
Copy link

njbbaer commented Jan 6, 2022

Looks great, thank you! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request WIP Work In Process
Projects
None yet
Development

No branches or pull requests

3 participants