Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview code block font doesn't follow editor.fontFamily setting #672

Closed
yume-chan opened this issue Jan 11, 2022 · 3 comments
Closed

Comments

@yume-chan
Copy link

Describe the bug

VSCode built in themes uses font-family: var(--vscode-editor-font-family) for code blocks in Markdown preview, which refers to the editor.fontFamily setting and that's what the editor uses.

But this extension's style overrided it to Menlo, which doesn't support font ligatures.

To Reproduce
Steps to reproduce the behavior:

  1. Set editor.fontFamily to some font you like
  2. Open a Markdown file containing code blocks
  3. Open Preview

Expected behavior
Code blocks in Markdown preview uses the same font as editor.fontFamily

Screenshots & Example Code

With "editor.fontFamily": "\"Cascadia Code\""

Code:

```
!=
```

Dark+ theme:

image

One Dark Pro theme:

image

Desktop (please complete the following information):

  • OS: macOS 12.1
  • VSCODE Version: 1.63.2
  • Theme version: 3.13.10
@yume-chan yume-chan added the bug label Jan 11, 2022
Binaryify added a commit that referenced this issue Jan 13, 2022
@Binaryify
Copy link
Owner

plz check v3.13.11~

@kossa
Copy link

kossa commented Jan 13, 2022

Alright it works fine

image

@yume-chan
Copy link
Author

image

Fix verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants