Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to access atomic descriptors #58

Open
bernstei opened this issue Oct 13, 2020 · 4 comments
Open

no way to access atomic descriptors #58

bernstei opened this issue Oct 13, 2020 · 4 comments

Comments

@bernstei
Copy link
Collaborator

There is a function that computes atomic descriptors, compute_atomic_descriptors, and these are saved in self.atomic_desc, but from what I can tell, there is no function that retrieves those (similar to fetch_computed_descriptors which appears to only get global descriptors). This means that there's no way to generate that atomic descriptor design matrix without going through a file, since get_atomic_descriptors does appear to read them.

@bernstei
Copy link
Collaborator Author

bernstei commented Oct 13, 2020

Note that from what I can tell if you call compute_atomic_descriptors but not compute_global_descriptors, you get an ASAPXYZ object that cannot be written. If you want to write it (so you can read it back in and use get_atomic_descriptors), you have to call compute_global_descriptors with keep_atomic=True. I'll put together an example of this.

@BingqingCheng
Copy link
Owner

I think you are right. I'm a bit snowed under these couple of days but will fix it before the end of the week.

@bernstei
Copy link
Collaborator Author

bernstei commented Oct 13, 2020 via email

@BingqingCheng
Copy link
Owner

This is done now. In summary, one can just compute atomic_descriptors using, e.g.

compute atomic descriptors only

asapxyz.compute_atomic_descriptors(desc_spec_dict=soap_spec,
sbs=[],
tag='tio2-atomic',
n_process=1)

and fetch it by:
dm = asapxyz.fetch_computed_atomic_descriptors(['soap1'])

Will update the documentation shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants