Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x, y, z seem too generic to export #49

Closed
timholy opened this issue May 24, 2024 · 3 comments
Closed

x, y, z seem too generic to export #49

timholy opened this issue May 24, 2024 · 3 comments
Labels

Comments

@timholy
Copy link
Contributor

timholy commented May 24, 2024

These conflict with variables of the same names. For example, if one wanted to plot all the atoms, one can imagine passing variables x, y, z to Makie. x!, y!, and z! are only a tiny bit better, these just seem like names that BioStructures should not claim to own.

@jgreener64
Copy link
Member

I'm happy to not export these.

It will be a breaking change though, so if you have any other suggestions we could roll them into one release.

@timholy
Copy link
Contributor Author

timholy commented May 24, 2024

Agreed, that was the purpose of reporting without a PR. Can you put a "breaking" label on this? (I can't.)

@jgreener64
Copy link
Member

x, x!, etc. are no longer exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants