Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More conservative autodetection of sequence type #59

Closed
jakobnissen opened this issue Nov 22, 2021 · 2 comments
Closed

More conservative autodetection of sequence type #59

jakobnissen opened this issue Nov 22, 2021 · 2 comments

Comments

@jakobnissen
Copy link
Member

DNA/RNA sequences with just a few ambiguous characters will be detected as amino acid sequences.
Perhaps a better scheme is to check if all characters are translatable in first DNA, then RNA, then AA.
@jakobnissen
Copy link
Member Author

Actually, based on the Slack conversation, maybe it's better just to remove autodetection alltogether. Since it apparently causes issues with users getting unexpected sequences, it's bad for type stability, and it's one of those API decisions that makes it hard to write robust scripts/software that doesn't fail when it encounters an edge case.

@jakobnissen
Copy link
Member Author

Implemented on release-2 branch, closing.

@jakobnissen jakobnissen mentioned this issue Feb 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakobnissen