Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic for classNames from template to controller #58

Closed
2 tasks done
BioPhoton opened this issue Apr 7, 2017 · 0 comments
Closed
2 tasks done

Move logic for classNames from template to controller #58

BioPhoton opened this issue Apr 7, 2017 · 0 comments
Labels
enhancement

Comments

@BioPhoton
Copy link
Owner

BioPhoton commented Apr 7, 2017 •
edited

Currently the logic for generating the class names is placed in the template and is pretty clumsy there.

Things to do:

  • reate a getComponentClassNames() :string function and rebuild the template logic there
  • use the created function in the template
BioPhoton added a commit that referenced this issue Apr 7, 2017
@BioPhoton
Merge pull request #59 from BioPhoton/dev
0dafd43 
Changes:

- [ ] Updated new version of  css-star-rating to 1.2.10
- [ ] Implemented labelHidden property
- [ ] Implemented hover functionality

This PR closes #58 #56 #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BioPhoton