New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
biscuiteerData #1270
Comments
Hi @jamorrison Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
Add SSH keys to your GitHub account. SSH keys |
A reviewer has been assigned to your package. Learn what to expect IMPORTANT: Please read the instructions for setting |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR, WARNINGS". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
AdditionalPackage: https://github.com/trichelab/biscuiteer |
Hi @jamorrison, Starting build on additional package https://github.com/trichelab/biscuiteer. IMPORTANT: Please read the instructions for setting up a The DESCRIPTION file of this additional package is:
|
Mentioning @ttriche to look at package. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Hi @nturaga biscuiteerData and biscuiteer are ready to be reviewed. Let me know what elements I need to change. Thank you. |
Sorry for the delay - I will be taking over the review for now - I am currently looking at the packages and will post feedback within the next few hours |
Thank you for your submission please see initial comments below: Data packageREADME
NEWS
DESCRIPTION
R/man data.R
Software packageBuild report
README
NEWS
LICENSE
test
inst
Clarification
Vignette
-[ ] section 2.3 while it is quick, it seems like wasted effort to recreate the
R / man WGVSage.R
atRegions.R
binCoverage.R
biscuitMetadata.R
byExtremality.R
checkBiscuitBED.R
data.R
extremality.R
fexpit.R
filterLoci.R
fixNA.R
flogit.R
getLogitFracMeth.R
loadHDF5.R
read.biscuit.R
saveHDF5.R
Please revise the packages according to above. When ready please comment here summarizing the changes. Please also remember to do a version bump to trigger a new build report and ping me in a message indicating you are ready for another review. Cheers! |
Hi @lshep I wanted to let you know that I started making changes based on the corrections you requested. I will have those done early next week and answer any clarifications at that point. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Hi @lshep I have addressed the comments you made in your review. Please see below for responses. Data packageREADME
NEWS
DESCRIPTION
R/man data.R
Software packageBuild report
README
NEWS
LICENSE
test
inst
Clarification
Vignette
R / man WGBSage.R
atRegions.R
binCoverage.R
biscuitMetadata.R
byExtremality.R
checkBiscuitBED.R
data.R
extremality.R
fexpit.R
filterLoci.R
fixNA.R
flogit.R
getLogitFracMeth.R
loadHDF5.R
read.biscuit.R
saveHDF5.R
Let me know if you have further requests for changes to be made. |
Thank you. I have no further comments at this time. I look forward to seeing the future developments of this package as well. |
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/jamorrison.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/biscuiteerData If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/jamorrison.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/biscuiteer If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: