New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gg4way #3129
Comments
Hi @ben-laufer Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
Your package has been added to git.bioconductor.org to continue the IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Build System. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. The following are build products from R CMD build on the Bioconductor Build Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
A reviewer has been assigned to your package for an indepth review. |
Your package has been added to git.bioconductor.org to continue the IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Build System. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Bioconductor Build Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Your package has been added to git.bioconductor.org to continue the IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Build System. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Bioconductor Build Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Hi @ben-laufer, Thank you for submitting gg4way to Bioconductor. The package is largely fine as is, but I did want to ask whether you considered implementing In my review below I have separated the issues into Required and Recommended points that I would ask you to address before the package can be accepted. I'll be on leave (and offline) from today until October 9. Cheers, Required
library(gg4way)
#> Loading required package: ggplot2
data("airwayFit")
airwayFit |>
tidyDGE() |>
gg4way(x = "N61311 vs N052611",
y = "N061011 vs N052611",
# Force all genes to be 'significant'.
FDRcutoff = 1,
logFCcutoff = 0)
#> Warning: Removed 1 rows containing missing values (`geom_label()`). Session infosessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#> setting value
#> version R version 4.3.1 (2023-06-16)
#> os macOS Ventura 13.6
#> system aarch64, darwin20
#> ui X11
#> language (EN)
#> collate en_US.UTF-8
#> ctype en_US.UTF-8
#> tz Australia/Melbourne
#> date 2023-09-28
#> pandoc 3.1.1 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/ (via rmarkdown)
#>
#> ─ Packages ───────────────────────────────────────────────────────────────────
#> package * version date (UTC) lib source
#> abind 1.4-5 2016-07-21 [1] CRAN (R 4.3.0)
#> Biobase 2.61.0 2023-04-25 [1] Bioconductor
#> BiocGenerics 0.47.0 2023-04-25 [1] Bioconductor
#> BiocParallel 1.35.4 2023-08-17 [1] Bioconductor
#> bitops 1.0-7 2021-04-24 [1] CRAN (R 4.3.0)
#> cli 3.6.1 2023-03-23 [1] CRAN (R 4.3.0)
#> codetools 0.2-19 2023-02-01 [1] CRAN (R 4.3.1)
#> colorspace 2.1-0 2023-01-23 [1] CRAN (R 4.3.0)
#> crayon 1.5.2 2022-09-29 [1] CRAN (R 4.3.0)
#> curl 5.0.2 2023-08-14 [1] CRAN (R 4.3.0)
#> DelayedArray 0.27.10 2023-07-28 [1] Bioconductor
#> DESeq2 1.41.11 2023-09-25 [1] Bioconductor
#> digest 0.6.33 2023-07-07 [1] CRAN (R 4.3.0)
#> dplyr 1.1.3 2023-09-03 [1] CRAN (R 4.3.0)
#> evaluate 0.21 2023-05-05 [1] CRAN (R 4.3.0)
#> fansi 1.0.4 2023-01-22 [1] CRAN (R 4.3.0)
#> farver 2.1.1 2022-07-06 [1] CRAN (R 4.3.0)
#> fastmap 1.1.1 2023-02-24 [1] CRAN (R 4.3.0)
#> fs 1.6.3 2023-07-20 [1] CRAN (R 4.3.0)
#> generics 0.1.3 2022-07-05 [1] CRAN (R 4.3.0)
#> GenomeInfoDb 1.37.4 2023-09-07 [1] Bioconductor
#> GenomeInfoDbData 1.2.10 2023-03-26 [1] Bioconductor
#> GenomicRanges 1.53.1 2023-05-04 [1] Bioconductor
#> gg4way * 0.99.0 2023-09-27 [1] Bioconductor
#> ggplot2 * 3.4.3 2023-08-14 [1] CRAN (R 4.3.0)
#> glue 1.6.2 2022-02-24 [1] CRAN (R 4.3.0)
#> gtable 0.3.4 2023-08-21 [1] CRAN (R 4.3.1)
#> htmltools 0.5.6 2023-08-10 [1] CRAN (R 4.3.0)
#> IRanges 2.35.2 2023-06-23 [1] Bioconductor
#> janitor 2.2.0 2023-02-02 [1] CRAN (R 4.3.0)
#> knitr 1.44 2023-09-11 [1] CRAN (R 4.3.1)
#> labeling 0.4.3 2023-08-29 [1] CRAN (R 4.3.0)
#> lattice 0.21-8 2023-04-05 [1] CRAN (R 4.3.1)
#> lifecycle 1.0.3 2022-10-07 [1] CRAN (R 4.3.0)
#> limma 3.57.8 2023-09-24 [1] Bioconductor
#> locfit 1.5-9.8 2023-06-11 [1] CRAN (R 4.3.0)
#> lubridate 1.9.3 2023-09-27 [1] CRAN (R 4.3.1)
#> magrittr 2.0.3 2022-03-30 [1] CRAN (R 4.3.0)
#> Matrix 1.6-1.1 2023-09-18 [1] CRAN (R 4.3.1)
#> MatrixGenerics 1.13.1 2023-06-09 [1] Github (Bioconductor/MatrixGenerics@8ecd537)
#> matrixStats 1.0.0 2023-06-02 [1] CRAN (R 4.3.0)
#> munsell 0.5.0 2018-06-12 [1] CRAN (R 4.3.0)
#> pillar 1.9.0 2023-03-22 [1] CRAN (R 4.3.0)
#> pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 4.3.0)
#> purrr 1.0.2 2023-08-10 [1] CRAN (R 4.3.0)
#> R6 2.5.1 2021-08-19 [1] CRAN (R 4.3.0)
#> Rcpp 1.0.11 2023-07-06 [1] CRAN (R 4.3.0)
#> RCurl 1.98-1.12 2023-03-27 [1] CRAN (R 4.3.0)
#> reprex 2.0.2 2022-08-17 [1] CRAN (R 4.3.0)
#> rlang 1.1.1 2023-04-28 [1] CRAN (R 4.3.0)
#> rmarkdown 2.25 2023-09-18 [1] CRAN (R 4.3.1)
#> rstudioapi 0.15.0 2023-07-07 [1] CRAN (R 4.3.0)
#> S4Arrays 1.1.6 2023-08-31 [1] Bioconductor
#> S4Vectors 0.39.2 2023-09-22 [1] Bioconductor
#> scales 1.2.1 2022-08-20 [1] CRAN (R 4.3.0)
#> sessioninfo 1.2.2 2021-12-06 [1] CRAN (R 4.3.0)
#> snakecase 0.11.1 2023-08-27 [1] CRAN (R 4.3.0)
#> SparseArray 1.1.12 2023-08-31 [1] Bioconductor
#> statmod 1.5.0 2023-01-06 [1] CRAN (R 4.3.0)
#> stringi 1.7.12 2023-01-11 [1] CRAN (R 4.3.0)
#> stringr 1.5.0 2022-12-02 [1] CRAN (R 4.3.0)
#> SummarizedExperiment 1.31.1 2023-05-01 [1] Bioconductor
#> tibble 3.2.1 2023-03-20 [1] CRAN (R 4.3.0)
#> tidyr 1.3.0 2023-01-24 [1] CRAN (R 4.3.0)
#> tidyselect 1.2.0 2022-10-10 [1] CRAN (R 4.3.0)
#> timechange 0.2.0 2023-01-11 [1] CRAN (R 4.3.0)
#> utf8 1.2.3 2023-01-31 [1] CRAN (R 4.3.0)
#> vctrs 0.6.3 2023-06-14 [1] CRAN (R 4.3.0)
#> withr 2.5.1 2023-09-26 [1] CRAN (R 4.3.1)
#> xfun 0.40 2023-08-09 [1] CRAN (R 4.3.0)
#> xml2 1.3.5 2023-07-06 [1] CRAN (R 4.3.0)
#> XVector 0.41.1 2023-05-03 [1] Bioconductor
#> yaml 2.3.7 2023-01-23 [1] CRAN (R 4.3.0)
#> zlibbioc 1.47.0 2023-04-25 [1] Bioconductor
#>
#> [1] /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library
#>
#> ────────────────────────────────────────────────────────────────────────────── Recommended
Footnotes
|
Received a valid push on git.bioconductor.org; starting a build for commit id: 33f5d1d51207ee39e1e38d869ee1062283d9d8a0 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Build System. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Bioconductor Build Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Hi @PeteHaitch, Thanks for reviewing gg4way. All the required changes have been made. See below for a point-by-point response about the improvements.
Required
The man page for
The
This has been clarified in the argument descriptions.
The "other packages" section of the vignette (and function documentation) mention that the symbol column is optional and used for the plot labels. It enables cases where not every feature has a (unique) gene ID. The ID column is how unique features are defined.
I have added a note about this to the details section of the man page for
The documentation for the arguments now mention that this is referring to the DEG totals for each category of gene overlap, which is shown by the numeric text in the plot.
Added to the description section of the man page and mentioned in the vignette.
In-text values are now obtained from inline R code.
Let me know if it's missing any key details.
This has been fixed and additional error checks have been added. Recommended
Support for a list of DGELRT objects from edgeR has been added to
Three extractor functions have been added, each of which return a distinct object. They are:
The documentation now refers to a list of data.frame objects.
Support has been added for the output of the
Added.
These links will be added upon acceptance.
The description file has been modified to generate a better default citation.
An additional unit test has been added.
That one slipped through my R Studio spell check.
|
I'm happy to mark gg4way as accepted. A few final, minor things to address:
|
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! Reviewers for Bioconductor packages are volunteers from the Bioconductor |
The default branch of your GitHub repository has been added to Bioconductor's To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/ben-laufer.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/gg4way If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand Bioconductor Package Naming Policy and acknowledge
Bioconductor may retain use of package name.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the Bioconductor code of conduct and
agree to abide by it.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.
The text was updated successfully, but these errors were encountered: