Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mspms #3460

Open
10 tasks done
baynec2 opened this issue Jun 17, 2024 · 3 comments
Open
10 tasks done

mspms #3460

baynec2 opened this issue Jun 17, 2024 · 3 comments
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3e. pending pre-review changes review has indicated blocking concern that needs attention

Comments

@baynec2
Copy link

baynec2 commented Jun 17, 2024

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @baynec2

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: mspms
Type: Package
Title: Analysis tools for use with MSP-MS
Version: 0.99.0
Authors@R: person("Charlie", "Bayne", email = "baynec2@gmail.com",
    role = c("aut", "cre"))
Description: This package provides functions for the analysis of data generated 
    by the multiplex substrate profiling by mass spectrometry for proteases 
    (MSP-MS) method.Data exported from upstream proteomics software is accepted 
    as input and subsequently normalized, outlier removed, and imputed. 
    Tools for statistical analysis, visualization, and interpretation of 
    the data are provided.
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.3.1
Depends: 
    R (>= 4.1.0)
biocViews: Proteomics, MassSpectrometry
Imports: 
    dplyr (>= 1.1.4),
    magrittr (>= 2.0.3),
    MASS (>= 7.3.60.0.1),
    NormalyzerDE (>= 1.19.7),
    outliers (>= 0.15),
    purrr (>= 1.0.2),
    stats (>= 4.1.1),
    tidyr (>= 1.3.1),
    truncnorm (>= 1.0.9),
    utils (>= 4.1.1),
    ggplot2 (>= 3.5.0),
    ggseqlogo (>= 0.2),
    heatmaply (>= 1.5.0),
    readr (>= 1.1.5),
    readxl (>= 1.4.3),
    rstatix (>= 0.7.2),
    tibble (>= 3.2.1),
    SummarizedExperiment (>= 1.24.0),
    rlang (>= 1.1.3),
    forcats (>= 1.0.0),
    ggpubr (>= 0.6.0),
    rmarkdown (>= 2.26),
    DT (>= 0.33)
Suggests: 
    knitr,
    testthat (>= 3.0.0)
Config/testthat/edition: 3
URL: https://github.com/baynec2/mspms
BugReports: https://github.com/baynec2/mspms/issues
VignetteBuilder: knitr

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Jun 17, 2024
@lshep
Copy link
Contributor

lshep commented Jun 24, 2024

Could you please provide an abstract/intro section in your vignette that
provides motivation for inclusion in Bioconductor and when appropriate a review
and comparison to existing Bioconductor packages with similar functionality or
scope.

Please do not hard code paths in vignettes/examples/tests. For example

"../tests/testdata/protein-peptides-lfq.csv"

Data should be in a inst/extdata directory and data should be
well documented on source, licensing, and how it was generated either with a file in inst/script that can be text, pseudo code or code but detail how a user could procure or created the files in inst/extadata. Then retrieve the path with system.file().

@lshep lshep added the 3e. pending pre-review changes review has indicated blocking concern that needs attention label Jun 24, 2024
@baynec2
Copy link
Author

baynec2 commented Jun 25, 2024

Just edited as you suggested and pushed changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3e. pending pre-review changes review has indicated blocking concern that needs attention
Projects
None yet
Development

No branches or pull requests

3 participants