completion improvements #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional monkey patching, to handle it being installed in projects that does not have `gevent` as an requirement. fixes Biometria-se/grizzly#299.
fixed problem in Biometria-se/grizzly#296. implemented better support for `And` and `But`, since they depend on a non-"one of those" steps arbritary number of lines above. now when completing with those, it will only return suggestions related to the identified "base" keyword above it, instead of all. client/vscode completion tests has been greatly approved by actually accepting a suggestion and verifying that the complete line turned out as expected. that is a hack though, since there are no events to listen for that would tell you that the UI is done, so sleeps are introduced :( one of the sleeps could be removed by adding a onDidTextDocumentChange listener, but it should be removed after each time it has executed, and then it becomes a chicken-and-egg problem...
boffman
approved these changes
Dec 20, 2023
and other packages that had newer versions. vscode 1.85.1 had some changes which broke the test package.
...at least locally.
also install `@vscode/vsce` instead of `vsce`.
removed debug logging. ms-python.python extension, which provide the @vscode/python-extension API had problems selecting the correct python environment, causing the tests to fail since the language server couldn't be started. the language server module was installed in the environment action/setup-python had configured. in the runner a version of 3.8 through 3.12 was installed, and for some reason the extension (on windows and mac) decided that the active environment was the highest version...
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed problem in Biometria-se/grizzly#296.
implemented better support for
AndandBut, since they depend on a non-"one of those" steps arbritary number of lines above. now when completing with those, it will only return suggestions related to the identified "base" keyword above it, instead of all.client/vscodecompletion tests has been greatly approved by actually accepting a suggestion and verifying that the completef line turned out as expected. that is a hack though, since there are no events to listen for that would tell you that the UI is done, so sleeps are introduced :(ms-python.pythonand it's@vscode/python-extensionAPI is buggy when it comes to selecting python environment, seems like it does not take which python environment that is active when executing into consideration at all.workaround this in the extension by looking if
VIRTUAL_ENVenvironment variable is set, and use the value of that to resolve the environment used.in the workflow
action/setup-pythonwill set environment variablepythonLocationfor the environment that is configured. so when running the client test we setVIRTUAL_ENVto the value ofpythonLocation.