Add tests for invalid Filter comparison

Bionus · Aug 6, 2018 · 03d20be · 03d20be
1 parent cfabd99
commit 03d20be
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/tests/src/models/filtering/meta-filter-test.cpp b/tests/src/models/filtering/meta-filter-test.cpp
@@ -1,6 +1,7 @@
 #include "meta-filter-test.h"
 #include <QtTest>
 #include "models/filtering/meta-filter.h"
+#include "models/filtering/tag-filter.h"
 #include "loader/token.h"
 
 
@@ -16,6 +17,7 @@ void MetaFilterTest::testCompare()
 	QCOMPARE(MetaFilter("meta", "val") == MetaFilter("meta", "val", true), false);
 	QCOMPARE(MetaFilter("meta", "val") == MetaFilter("another meta", "val"), false);
 	QCOMPARE(MetaFilter("meta", "val") == MetaFilter("meta", "another val"), false);
+	QCOMPARE(MetaFilter("meta", "val") == TagFilter("tag"), false);
 }
 
 void MetaFilterTest::testMatchInvalidToken()

diff --git a/tests/src/models/filtering/tag-filter-test.cpp b/tests/src/models/filtering/tag-filter-test.cpp
@@ -1,6 +1,7 @@
 #include "tag-filter-test.h"
 #include <QtTest>
 #include "models/filtering/tag-filter.h"
+#include "models/filtering/token-filter.h"
 #include "loader/token.h"
 
 
@@ -15,6 +16,7 @@ void TagFilterTest::testCompare()
 	QCOMPARE(TagFilter("test") == TagFilter("test"), true);
 	QCOMPARE(TagFilter("test") == TagFilter("test", true), false);
 	QCOMPARE(TagFilter("test") == TagFilter("another test"), false);
+	QCOMPARE(TagFilter("test") == TokenFilter("token"), false);
 }
 
 void TagFilterTest::testMatchExact()

diff --git a/tests/src/models/filtering/token-filter-test.cpp b/tests/src/models/filtering/token-filter-test.cpp
@@ -1,5 +1,6 @@
 #include "token-filter-test.h"
 #include <QtTest>
+#include "models/filtering/tag-filter.h"
 #include "models/filtering/token-filter.h"
 #include "loader/token.h"
 
@@ -15,6 +16,7 @@ void TokenFilterTest::testCompare()
 	QCOMPARE(TokenFilter("test") == TokenFilter("test"), true);
 	QCOMPARE(TokenFilter("test") == TokenFilter("test", true), false);
 	QCOMPARE(TokenFilter("test") == TokenFilter("another test"), false);
+	QCOMPARE(TokenFilter("test") == TagFilter("tag"), false);
 }
 
 void TokenFilterTest::testMatchInt()