Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source sankaku complex isn't able to get the estimated count of images/pages #1363

Closed
MrAndre96 opened this issue Aug 9, 2018 · 4 comments
Closed
Assignees
Labels
bug reproduced This issue was reproduced by the assignee. source
Milestone

Comments

@MrAndre96
Copy link
Contributor

Bug description

When you search for a tag with a high number of results or a tag with less results but you add a second search tag to it it will not be able to get a estimated amount of results.

Steps to reproduce

When you search for example gochuumon_wa_usagi_desu_ka? it has a lot of results but this source isn't able to get the estimated amount of results.
WHen you search nekopara it is able to get a estimated amount of results but when you add rating:safe to it, it will no longer be able to get a estimated amount of results.

Expected behavior

Like in version 6.0.3 I would like to see the estimated amount of results so you can use get all on this source. Now you have to guess ti image limit when you click on get all.

Screenshots

https://i.imgur.com/I2w0Ssh.png
https://i.imgur.com/TIq4GRM.png
https://i.imgur.com/bYKXUg2.png

System information

Windows 10 with the nighly version 0de9670

@Bionus
Copy link
Owner

Bionus commented Aug 9, 2018

There are actually two problems.

  1. For gochuumon_wa_usagi_desu_ka?, I'm pretty sure it already couldn't guess the image count, as there was an issue which caused tags with question marks to not be parsed (and therefore, their image count either).
  2. Adding a rating:safe to a search should indeed still use the other tags' "max image count".

@Bionus Bionus self-assigned this Aug 9, 2018
@Bionus Bionus added bug source reproduced This issue was reproduced by the assignee. labels Aug 9, 2018
@Bionus Bionus added this to the v6.0.5 milestone Aug 9, 2018
@MrAndre96
Copy link
Contributor Author

@Bionus could you also look into the problem when you use for example swimsuit as second tag it will be able to estimate the amount of results but when you add - before swimsuit it is not able to estimate it anymore. Using the nightly version with the fixes above.
https://i.imgur.com/2fpoeme.png
https://i.imgur.com/Y3OCelm.png

@MrAndre96
Copy link
Contributor Author

MrAndre96 commented Aug 10, 2018

@Bionus when you search with just this tag otome_domain without anything else it is also not able to estimate the pages/images. This is caused probably since the tag is orginally otome_*_domain but sankaku complex has something which made otome_domain also work

@Bionus
Copy link
Owner

Bionus commented Aug 12, 2018

image

Sankaku clearly reports 0 images for this tag, while still returning results.
Nothing Grabber can do about that, I would instead file a bug report on Sankaku's forums. 👌

@Bionus Bionus closed this as completed in e02675d Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproduced This issue was reproduced by the assignee. source
Projects
None yet
Development

No branches or pull requests

2 participants