Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Mention auto-complete order should be displayed like in Discord app #170

Open
n4n0GH opened this issue Oct 7, 2019 · 14 comments
Open

Mention auto-complete order should be displayed like in Discord app #170

n4n0GH opened this issue Oct 7, 2019 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@n4n0GH
Copy link

n4n0GH commented Oct 7, 2019

What do you want

Order mention when using the auto-complete function (that is: type @ and cordless brings up the list of possible names to interact with), should work the same as in the official Discord app where the order is specified by which user was active last in the current chat.
Currently the implementation just pulls the complete user list from the server and displays them in alphabetical order.

Why

Some users have untaggable names because they are using either emojis or other untypable unicode characters in their names. Finding those users in the sometimes endlessly long list of users (in my example a discord with over 20K users) is not only cumbersome but sometimes outright impossible.

Implementation hints

The initial auto-complete window could show up the 10 most recent users, whereas beginning to type would bring back the current behaviour.

@Bios-Marcel
Copy link
Owner

@avahe-kellenberger

🏃‍♂️

@Bios-Marcel Bios-Marcel added the enhancement New feature or request label Oct 7, 2019
@avahe-kellenberger
Copy link
Collaborator

avahe-kellenberger commented Oct 7, 2019

I like the idea of showing most recently active users. Just as a tip, the new @mention in cordless uses fuzzy matching, so that may help you with typing usernames with strange starting characters (just type any part of their name, it doesn't need to be the first part of their name).

If @Bios-Marcel approves this feature change I'll implement it.

@Bios-Marcel
Copy link
Owner

I appprove

@n4n0GH
Copy link
Author

n4n0GH commented Oct 8, 2019

fuzzy matching

Completely useless if the user uses UNICODE characters exclusively. Looking forward to the update :3

@Bios-Marcel
Copy link
Owner

@avahe-kellenberger Any clue when you'll start working on this / have it finished?

@avahe-kellenberger
Copy link
Collaborator

Just type the unicode characters /s
I imagine I'll have it done by the end of this weekend, but I'm curious if there are any additional ways we could improve search functionality for odd usernames. Are their discord tags entirely unicode, or just their nick/usernames? Getting some examples would be great.

@n4n0GH
Copy link
Author

n4n0GH commented Oct 10, 2019

Yes, in that case their nicknames as well as their usernames consist of untypable unicodes like ∿ or ⚡.
Imo it's something discord should handle by not allowing users to rename their username to that but oh well.

@avahe-kellenberger
Copy link
Collaborator

Best duct tape solution I can think of atm is to type the suffix of their username (like #1234) for the time being. I'm still contemplating better fixes to search usernames in general.

@n4n0GH
Copy link
Author

n4n0GH commented Oct 11, 2019 via email

@Bios-Marcel
Copy link
Owner

eh ... just fuck those people

we could just allow copying there name from the userlist or chat

@n4n0GH
Copy link
Author

n4n0GH commented Oct 11, 2019

Userlist would be okay, chat is already a given function anyway.

@Bios-Marcel
Copy link
Owner

no, its not. copy wont work with mouse enabled, as it overwrites selection behaviour

@n4n0GH
Copy link
Author

n4n0GH commented Oct 11, 2019

Uh. If you Alt+T the chat, put the cursor at the desired user, and hit R it starts a mention, does it not? o_O

@Bios-Marcel
Copy link
Owner

Riiiight

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants