Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics using headings without content #3912

Closed
StephDriver opened this issue Jan 24, 2024 · 0 comments · Fixed by #4171
Closed

metrics using headings without content #3912

StephDriver opened this issue Jan 24, 2024 · 0 comments · Fixed by #4171
Assignees
@ajrbyers
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development.
Milestone
A11y Improvements...

Comments

@StephDriver
Copy link
Contributor

The metrics on article pages are using headings to display content, such that the structure is a sequence of headings rather than there being any content.

eg. https://www.iastatedigitalpress.com/mmb/article/id/12473/

Image

has html structure where each of those metrics is an h5 inside a div with no content between the headings.

Consider - should individual metrics headings at all?
@StephDriver StephDriver changed the title content missing after heading metrics using headings without content Jan 24, 2024
@StephDriver StephDriver added the a11y Issues that relate to acessibility label Jan 24, 2024
@ajrbyers ajrbyers added the dev-ready This issue has been refined and is ready for development. label Mar 14, 2024
@StephDriver StephDriver added this to the A11y Phase 1 milestone Apr 10, 2024
@ajrbyers ajrbyers self-assigned this Apr 26, 2024
@ajrbyers ajrbyers mentioned this issue May 8, 2024
Merged
This was referenced May 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development.
Projects
Accessibility
Status: Done
Milestone
A11y Improvements - Phase 1
Development

Successfully merging a pull request may close this issue.

The OLH and Material themes no longer use header tags to display metrics. openlibhums/janeway
2 participants
@StephDriver @ajrbyers