Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean theme news article truncation mishandling line-breaks #4207

Open
StephDriver opened this issue May 30, 2024 · 2 comments
Open

Clean theme news article truncation mishandling line-breaks #4207

StephDriver opened this issue May 30, 2024 · 2 comments
Assignees
Labels
bug Something's not working VPAT Issue prioritised for VPAT improvements.

Comments

@StephDriver
Copy link
Contributor

StephDriver commented May 30, 2024

Describe the bug
Clean theme, Janeway 1.5.1. News Articles are truncated into a summary for use e.g. on homepage. When article text has a new line, this is ignored rather than replaced with a space, such that the strings run together. Does not always happen to every linebreak.

for example:
image
term!The runs together but expression. The does not
image

But then in
image

both Conference!This and editors.Our run together

image
@StephDriver StephDriver added the bug Something's not working label May 30, 2024
@joemull
Copy link
Member

joemull commented May 31, 2024

I'm not positive but I think your changes in #3831 would have fixed this.

@StephDriver
Copy link
Contributor Author

StephDriver commented Jun 3, 2024

I'm not positive but I think your changes in #3831 would have fixed this.

that might explain my déjà vu when investigating this.

But I'm not sure it does fix it. I think the issue here is that it's fine when there is a trailing whitespace at the end of the previous line, but not when not - which suggests to me that lines are being concatenated without any whitespace added. I don't recall specifically testing for that behaviour when making the #3831 fix.

Assigning this to myself to investigate (I'll test the update for this specific behaviour).

@StephDriver StephDriver self-assigned this Jun 3, 2024
@StephDriver StephDriver added the VPAT Issue prioritised for VPAT improvements. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working VPAT Issue prioritised for VPAT improvements.
Projects
Status: Sent to Dev
Development

No branches or pull requests

2 participants