Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Theme Navigation Fixes #4227

Open
5 tasks
StephDriver opened this issue May 31, 2024 · 0 comments
Open
5 tasks

Clean Theme Navigation Fixes #4227

StephDriver opened this issue May 31, 2024 · 0 comments
Labels
a11y Issues that relate to acessibility VPAT Issue prioritised for VPAT improvements.

Comments

@StephDriver
Copy link
Contributor

StephDriver commented May 31, 2024

From screenreader testing (#4194), looking at the narrow screen navigation the following issues were identified:

  • Sample 3, item 5. menu items with dropdowns don't distinguish themselves from those which are links to other pages.
  • Sample 3, item 6. articles item (read out as "articles, link") opens a dropdown the first item of which is articles (read out as "articles, link). This is highly confusing!
  • Sample 3, item 7. likewise the second item under 'submissions' is also called 'submissions'
  • Sample 3, item 8. and again, 'About' has the first subitem as 'about'
  • Sample 3, item 9. Login and Register are a new list of two items, but part of the menu navigation landmark... confusing.

Dev notes
This a11y issue stems from the fact that top level nav items can have a path/link associated with them, while also having subnav. In order to provide the dropdown menu on click events, while also allowing the link to be navigable, the submenu renders a duplicate of the top level nav item.

Instead we have agreed the following actions:

  • Make has_sub_nav and link mutually exclusive
  • To add a data migration that will update any nav items that meet both conditions and wipe the link attribute. A sub nav item will be created using the same name and link as its parent.
@StephDriver StephDriver added the a11y Issues that relate to acessibility label May 31, 2024
This was referenced May 31, 2024
@StephDriver StephDriver added the VPAT Issue prioritised for VPAT improvements. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility VPAT Issue prioritised for VPAT improvements.
Projects
Status: Sent to Dev
Development

No branches or pull requests

1 participant