Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download versus View PDF confusion #4229

Open
StephDriver opened this issue May 31, 2024 · 2 comments
Open

Download versus View PDF confusion #4229

StephDriver opened this issue May 31, 2024 · 2 comments
Labels
a11y Issues that relate to acessibility

Comments

@StephDriver
Copy link
Contributor

Issue identified in #4194 Screen reader testing.

  • Sample 4, item 8. download / view PDF have same functionality in some browsers, unless you override?

Having these two links adjacent to each other is confusing when they have the same functionality in some browsers. Either we should force the download functionality to override and download, or have only one of them.

@StephDriver StephDriver added the a11y Issues that relate to acessibility label May 31, 2024
@mauromsl
Copy link
Member

mauromsl commented Jun 3, 2024

We already set the correct headers to indicate to browsers that the file is to be downloaded:

< HTTP/1.1 200 OK
< Server: nginx/1.18.0 (Ubuntu)
< Date: Mon, 03 Jun 2024 09:19:29 GMT
< Content-Type: application/pdf
< Content-Length: 4402301
< Connection: keep-alive
< Content-Disposition: attachment; filename="olh-10191-sutton.pdf"

Some browsers, even though they will correctly download the PDF, the do indeed immediately open the PDF, however it is done from a local URI, rather than from our URL. Some of our partner presses still want these metrics to be collected separately. If we were to only have one link, we would no longer be able to provide a download/view report accurately, and thus would need to provide a compelling reason to them.

@StephDriver
Copy link
Contributor Author

I've just tested this again on desktop, and observed the behaviour described by @mauromsl so I think the original behaviour I observed may have been because I was testing on a smartphone

In which case the only concern I have that remains is having both 'download' and 'view' under the heading 'download'.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility
Projects
Status: Debate
Development

No branches or pull requests

2 participants