Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document manager file upload error #3746

Open
everreau opened this issue Oct 2, 2023 · 3 comments · May be fixed by #4292
Open

Document manager file upload error #3746

everreau opened this issue Oct 2, 2023 · 3 comments · May be fixed by #4292
Assignees
@StephDriver
Labels
bug Something's not working

Comments

@everreau
Copy link
Contributor

everreau commented Oct 2, 2023

Describe the bug
When a user attempts to upload a file but clicks an upload button that does not correspond to the document field it causes a server error

Janeway version
1.5.0

To Reproduce

  1. Go to document management for any article
  2. Click "Upload File"
  3. Fill in file label
  4. Select a document under "New Manuscript File"
  5. Click the "Upload" button in the "Figure/Data File" section

Expected behavior
Probably this should cause a form error indicating there is no file to upload but also the interface could be changed so there aren't a bunch of different upload buttons.

Front-end Issues

If the issue is front-end specific please add the following details:

Desktop (please complete the following information):

  • MacOS 13.2.1
  • Firefox 118.0.1
@everreau everreau added the bug Something's not working label Oct 2, 2023
@StephDriver
Copy link
Contributor

Investigated, and this particular bug squashed, but then failed tests, which when compared to original, were also failed by master branch.

-The manuscript and data files upload fine.
-The production files upload as manuscript.
-The proofing files appear to cause an infinite loop of uploads, requiring test server to be halted.

these must be addressed before this issue can be resolved.

@StephDriver
Copy link
Contributor

proposed bugfix:

Instead of a single upload button leading to a popup with multiple file upload options, multiple file upload buttons leading to a popup for uploading that specific file type:

so from this:
image
image

to this:

image image

with similar popups for each of the other file types.

@StephDriver StephDriver mentioned this issue Dec 18, 2023
Closed
@ajrbyers ajrbyers linked a pull request Jan 16, 2024 that will close this issue
initial solution, but found related bugs #3847
Closed
@StephDriver
Copy link
Contributor

Initial solution to be replaced as per reviewer comment on #3847

Thanks for this StephDriver. Rather than having 4 buttons and 4 modals could we instead have a single button and a single popup and use a drop down for the file type on the form?

@StephDriver StephDriver linked a pull request Jun 24, 2024 that will close this issue
Open
@joemull joemull mentioned this issue Jul 15, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephDriver StephDriver

Labels
bug Something's not working
Projects
None yet
Milestone
No milestone
2 participants
@everreau @StephDriver