Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable @defichain-apps/nest-apps from being published #1111

Closed
fuxingloh opened this issue Feb 28, 2022 · 0 comments · Fixed by #1113
Closed

disable @defichain-apps/nest-apps from being published #1111

fuxingloh opened this issue Feb 28, 2022 · 0 comments · Fixed by #1113
Assignees
@eli-lim
Labels
area/apps kind/bug Something isn't working priority/urgent-now Urgent fix, as fast as possible sig/ecosystem triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Member

What happened:

https://github.com/DeFiCh/jellyfish/runs/5354928246?check_suite_focus=true#step:9:1023

Add private: true at
https://github.com/DeFiCh/jellyfish/blob/429a7ed431ee649deef4538142e8c75ca4e1f69f/apps/package.json#L2
to disable nest-apps from being published into npm

/triage accepted
/assign @eli-lim
/area apps
/priority urgent-now
/sig ecosystem
@fuxingloh fuxingloh added the kind/bug Something isn't working label Feb 28, 2022
@defichain-bot defichain-bot added triage/accepted Triage has been accepted area/apps sig/ecosystem priority/urgent-now Urgent fix, as fast as possible labels Feb 28, 2022
@eli-lim eli-lim mentioned this issue Feb 28, 2022
Merged
chanakasameera added a commit that referenced this issue Mar 8, 2022
@chanakasameera
Jellyfish minor updates for DFI Payback of all dTokens #1111
6e857af
fuxingloh pushed a commit that referenced this issue Mar 30, 2022
@chanakasameera @surangap
feat(jellyfish-api-core): DFI Payback of all dTokens (#1190)
df81748 
* Jellyfish minor updates for DFI Payback of all dTokens #1111

* Added setGov test cases with loan_payback and loan_payback_fee_pct keys

* Added paybackloan api extention and a testcase

* Added paybackloan a new testcase

* Updated fortcanningroadheight

* Updated fortcanningroadheight

* Updated fortcanningroadheight

* Added dusd loan payback using dusd test

* Fixed failing gov tests.

* Updated account.md with new paybackfees and paybacktokens

* Updated PaybackLoanMetadata properly and test updates

* Updates for review comments - part 1 (Now burn info is checked)

* Updates for review comments - part 2 (burn info check, new test cases and paybackLoan method signature update)

* Updates for review comments - part 3 (payback multiple loans at once, new test cases)

* Minor fixes for CI test fails and interest calculation

* Updates for review comments - part 4 (Payback checking before hardfork and minor updates)

* Updates for review comments - part 5 (Now Tsla tokens are not minted)

* Added dftx interface for Payback Loan V2

* Updated loan.md with payback loan v2

* Ain image from https://github.com/DeFiCh/ain/actions/runs/2020075855

* Update for dftx loan payback v2

* Added tests for dftx loan payback v2

* Comments update about PaybackLoanV2

Co-authored-by: surangap <surangatco@gmail.com>

* Comments update about TokenPayback.dToken

Co-authored-by: surangap <surangatco@gmail.com>

Co-authored-by: surangap <surangatco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eli-lim eli-lim

Labels
area/apps kind/bug Something isn't working priority/urgent-now Urgent fix, as fast as possible sig/ecosystem triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(apps): disable nest-apps from being published into npm BirthdayResearch/jellyfishsdk
3 participants
@fuxingloh @eli-lim @defichain-bot