feat(apps/whale-api): add updatemasternode indexer #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump testcontainers to `grandcentral` with `master-1d169a75`. Fixes all broken tests and known regression from this change. Co-authored-by: Dilshan Madushanka <helloscoopz@gmail.com>
….ts` to match other tests (#1865) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: Uses to the assertion order used by all other tests. Uses a regex pattern to match instead of `toContain`. #### Additional comments?: As requested in #1841 (comment)
…#1854) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: Add tests for new fixes on defid v3.
fuxingloh
requested changes
Dec 1, 2022
| } | ||
| } | ||
|
|
||
| async indexStats (block: RawBlock, data: Masternode): Promise<void> { |
There was a problem hiding this comment.
Hmm, it won't make sense to indexStats for an update? Since statistically there isn't any changes for updates?
- count, no changes, updating doesn't change the amount of masternode?
- tvl, what's locked is still locked
There was a problem hiding this comment.
Have removed. 3538564
Comment on lines
78
to
90
| await this.masternodeMapper.put({ | ||
| id: data.nodeId, | ||
| sort: `${HexEncoder.encodeHeight(block.height)}${txn.txid}`, | ||
| ownerAddress: (ownerAddress !== null) ? ownerAddress : mn.ownerAddress, | ||
| operatorAddress: (operatorAddress !== null) ? operatorAddress : mn.operatorAddress, | ||
| creationHeight: block.height, | ||
| resignHeight: -1, | ||
| mintedBlocks: 0, | ||
| timelock: 0, | ||
| block: { hash: block.hash, height: block.height, medianTime: block.mediantime, time: block.time }, | ||
| collateral: txn.vout[1].value.toFixed(8), | ||
| updateRecords | ||
| }) |
There was a problem hiding this comment.
We shouldn't be replacing all the entries since it's an update, not a new creation.
There was a problem hiding this comment.
Updating an existing record would look something like this.
Comment on lines
149
to
151
| async invalidateBlockStart (block: RawBlock): Promise<void> { | ||
| await this.masternodeStatsMapper.delete(block.height) | ||
| } |
There was a problem hiding this comment.
Suggested change
| async invalidateBlockStart (block: RawBlock): Promise<void> { | |
| await this.masternodeStatsMapper.delete(block.height) | |
| } |
There was a problem hiding this comment.
Have removed. c545463
Comment on lines
114
to
120
| mapTimelockStats (latest: TimelockStats[], lockStats: TimelockStats): TimelockStats[] { | ||
| return latest.map(x => ({ | ||
| ...x, | ||
| count: x.weeks === lockStats.weeks ? (x.count - lockStats.count) : x.count, | ||
| tvl: x.weeks === lockStats.weeks ? new BigNumber(x.tvl).minus(lockStats.tvl).toFixed(8) : x.tvl | ||
| })) | ||
| } |
There was a problem hiding this comment.
Suggested change
| mapTimelockStats (latest: TimelockStats[], lockStats: TimelockStats): TimelockStats[] { | |
| return latest.map(x => ({ | |
| ...x, | |
| count: x.weeks === lockStats.weeks ? (x.count - lockStats.count) : x.count, | |
| tvl: x.weeks === lockStats.weeks ? new BigNumber(x.tvl).minus(lockStats.tvl).toFixed(8) : x.tvl | |
| })) | |
| } |
There was a problem hiding this comment.
Have removed. 3538564
shohamc1
previously approved these changes
Dec 7, 2022
infinia-yzl
previously approved these changes
Dec 12, 2022
helloscoopa
reviewed
Dec 12, 2022
apps/whale-api/src/module.indexer/model/dftx/update.masternode.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dilshan Madushanka <helloscoopz@gmail.com> Signed-off-by: Kven Ho <kven@cakedefi.com>
helloscoopa
reviewed
Dec 12, 2022
apps/whale-api/src/module.indexer/model/dftx/update.masternode.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dilshan Madushanka <helloscoopz@gmail.com> Signed-off-by: Kven Ho <kven@cakedefi.com>
helloscoopa
previously approved these changes
Dec 12, 2022
marktanrj
previously approved these changes
Dec 12, 2022
apps/whale-api/src/module.indexer/model/dftx/update.masternode.ts
Outdated
Show resolved
Hide resolved
|
|
Signed-off-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>
fuxingloh
dismissed stale reviews from marktanrj and helloscoopa
via
faf5589
…CreateMasternode (#1920) #### What this PR does / why we need it: This utilizes the "forward indexing" design; it doesn't require `whale-api` to be reindexed. It will automatically create a history entry to `MasternodeMapper`. You can update your `whale-api` node without this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
UpdateMasternodeIndexer extends DfTxIndexer<UpdateMasternode>to update the masternode index when the DfTx UpdaterMasternode transaction is created.Which issue(s) does this PR fixes?:
Fixes part of #1842