feat(jellyfish-address, jellyfish-wallet): add eth.fromScript #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
canonbrother
changed the title
canonbrother
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2157 +/- ##
==========================================
+ Coverage 90.19% 92.16% +1.97%
==========================================
Files 371 373 +2
Lines 11217 11243 +26
Branches 1463 1467 +4
==========================================
+ Hits 10117 10362 +245
+ Misses 1038 845 -193
+ Partials 62 36 -26
... and 76 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Docker build preview for jellyfish/apps is ready! Built with commit a331176
You can also get an immutable image with the commit hash
|
pierregee
approved these changes
Sep 26, 2023
canonbrother
requested review from
fuxingloh and
ivan-zynesis
as code owners
lykalabrada
approved these changes
Sep 26, 2023
fuxingloh
approved these changes
Sep 26, 2023
| @@ -15,7 +15,7 @@ import { calculateFeeP2WPKH } from './txn_fee' | |||
| import { TxnBuilderError, TxnBuilderErrorType } from './txn_builder_error' | |||
| import { EllipticPair } from '@defichain/jellyfish-crypto' | |||
| import { Network } from '@defichain/jellyfish-network' | |||
| import { ListUnspentQueryOptions } from '@defichain/jellyfish-api-core/dist/category/wallet' | |||
| import { ListUnspentQueryOptions } from '@defichain/jellyfish-api-core/src/category/wallet' | |||
There was a problem hiding this comment.
Suggested change
| import { ListUnspentQueryOptions } from '@defichain/jellyfish-api-core/src/category/wallet' | |
| import { ListUnspentQueryOptions } from '@defichain/jellyfish-api-core' |
It should be this, but frankly speaking jellyfish-transaction-builder shouldn't have access to jellyfish-api-core since it's agnostic
There was a problem hiding this comment.
fixed 32a416b
@pierregee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add
eth.fromScript(evmScript) -> evmAddrand "PR pool" some fixesWhich issue(s) does this PR fixes?:
srcon import e63af92Additional comments?: