Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP_CODES for stack #389

Merged
merged 20 commits into from
Jun 22, 2021
Merged

OP_CODES for stack #389

merged 20 commits into from
Jun 22, 2021

Conversation

aikchun
Copy link
Contributor

@aikchun aikchun commented Jun 18, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes part of #107

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jun 18, 2021

Code Climate has analyzed commit f49a60e and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: f49a60e

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d035e7a46c6800075e61d0

😎 Browse the preview: https://deploy-preview-389--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 18, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 20.36 KB (0%) 408 ms (0%) 170 ms (-6.84% 🔽) 577 ms

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #389 (2343f19) into main (00986ae) will increase coverage by 4.24%.
The diff coverage is 97.93%.

❗ Current head 2343f19 differs from pull request most recent head f49a60e. Consider uploading reports for the commit f49a60e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   92.98%   97.22%   +4.24%     
==========================================
  Files          10       94      +84     
  Lines         171     2742    +2571     
  Branches       19      344     +325     
==========================================
+ Hits          159     2666    +2507     
- Misses         12       76      +64     
Impacted Files Coverage Δ
...llyfish-transaction/src/buffer/buffer_bignumber.ts 100.00% <ø> (ø)
...jellyfish-transaction/src/buffer/buffer_bitmask.ts 100.00% <ø> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.50% <ø> (ø)
...jellyfish-transaction/src/buffer/buffer_varuint.ts 100.00% <ø> (ø)
packages/jellyfish-transaction/src/index.ts 100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/_buffer.ts 100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/bitwise.ts 100.00% <ø> (ø)
...ages/jellyfish-transaction/src/script/constants.ts 100.00% <ø> (ø)
...ckages/jellyfish-transaction/src/script/control.ts 100.00% <ø> (ø)
...ackages/jellyfish-transaction/src/script/crypto.ts 100.00% <ø> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e0dde...f49a60e. Read the comment docs.

@jingyi2811
Copy link
Contributor

@aikchun aikchun requested a review from jingyi2811 June 18, 2021 11:07
canonbrother
canonbrother previously approved these changes Jun 21, 2021
@fuxingloh fuxingloh merged commit d26d5e1 into main Jun 22, 2021
@fuxingloh fuxingloh deleted the aikchun/stack-ops branch June 22, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants