Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitwise OP CODES. #422

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Add bitwise OP CODES. #422

merged 2 commits into from
Jun 28, 2021

Conversation

surangap
Copy link
Contributor

@surangap surangap commented Jun 24, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds opcodes for biwise mentioned in #107

Which issue(s) does this PR fixes?:

Fixes part of #107

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jun 24, 2021

Code Climate has analyzed commit 6d8e07a and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jun 24, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 21.03 KB (0%) 421 ms (0%) 188 ms (+3.17% 🔺) 608 ms

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #422 (6d8e07a) into main (58fba5e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   97.30%   97.33%   +0.03%     
==========================================
  Files          95       96       +1     
  Lines        2778     2811      +33     
  Branches      351      354       +3     
==========================================
+ Hits         2703     2736      +33     
  Misses         75       75              
Impacted Files Coverage Δ
...ckages/jellyfish-transaction/src/script/mapping.ts 96.66% <ø> (ø)
...ckages/jellyfish-transaction/src/script/bitwise.ts 100.00% <100.00%> (ø)
packages/jellyfish-api-core/src/index.ts 100.00% <0.00%> (ø)
...es/jellyfish-api-core/src/category/icxorderbook.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fba5e...6d8e07a. Read the comment docs.

@surangap surangap marked this pull request as ready for review June 24, 2021 10:45
ivan-zynesis
ivan-zynesis previously approved these changes Jun 25, 2021
Copy link
Contributor

@canonbrother canonbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good
/kind feature need fuxing's approval

@netlify
Copy link

netlify bot commented Jun 28, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 6d8e07a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60d95fca5f60340008441833

😎 Browse the preview: https://deploy-preview-422--jellyfish-defi.netlify.app

@fuxingloh fuxingloh merged commit 7fa5f13 into main Jun 28, 2021
@fuxingloh fuxingloh deleted the surangap/bitwise-ops branch June 28, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants