Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runaway cat on fifo file when factorio stop is issued #185

Closed
tmzasz opened this issue Apr 2, 2021 · 3 comments
Closed

runaway cat on fifo file when factorio stop is issued #185

tmzasz opened this issue Apr 2, 2021 · 3 comments

Comments

@tmzasz
Copy link
Contributor

tmzasz commented Apr 2, 2021

when issuing factorio stop the tail on the server fifo gets replaced with a runaway cat that sits there using ram doing nothing on the root user
https://cdn.discordapp.com/attachments/627326922573086730/827397634355757057/unknown.png

tmzasz pushed a commit to tmzasz/factorio-init that referenced this issue Apr 2, 2021
@tmzasz tmzasz mentioned this issue Apr 2, 2021
@Bisa
Copy link
Owner

Bisa commented Jun 16, 2021

Which system are you running this on?
The code was introduced to fix another problem , see d601a6082c4eccef07909f5d1c90dd7942c4518c

Before I can accept the PR you made I'd need some test coverage to ensure the original issue does not return.
#helpwanted - or I'll get around to writing them myself at some point :)

@tmzasz
Copy link
Contributor Author

tmzasz commented Jun 16, 2021

ok so the system is CentOS Linux release 7.9.2009 (Core) using kernel 4.9.178
Yea i saw that but the issue it seems is the intended stop to the pipe does not actualy stop the pipe like it should as the opening cat ${FIFO} & command seems to prevent it from closing with the echo commands ( it still hangs ). Removing the cat ${FIFO} & part seems to allow the echo to properly close the cat.

@tmzasz
Copy link
Contributor Author

tmzasz commented Nov 3, 2021

so from what I can gather so far the fix does stop the run away cat on my machine ( tested through several factorio stop and box reboots now ) i think the manual startup of the reader is not necessary in this instance because the FIFO is already being tailed in the start_service() function on line # 319 and is just serving to open a second reader which results in a runaway cat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants