Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #9

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Improve performance #9

merged 5 commits into from
Apr 5, 2023

Conversation

Bisaloo
Copy link
Owner

@Bisaloo Bisaloo commented Apr 5, 2023

Fix #8

@Bisaloo
Improve detect_with_markers() performance
dc3f2f4 
~ x10 perf improvement

```r
library(microbenchmark)

x <- c("{{ test }}", "a", "{{ b }}", NA)

marker_open <- "{{"
marker_close <- "}}"

microbenchmark(
  { !is.na(x) & startsWith(x, marker_open) & endsWith(x, marker_close) } ,
  {
    esc_markers <- gsub("(\\[|\\]|[{}*?+()\\.|\\(\\)^$\\])", "\\\\\\1", c(marker_open, marker_close))

    grepl(
      paste0("^", esc_markers[1], ".*", esc_markers[2], "$"),
      x
    )
  },
  check = "identical"
)
```
@Bisaloo
Remove unnecessary escapes
f3d15c9
@Bisaloo
Replace remove_markers() function by substr()
1fdcca3 
since we know for sure we're only working with strings that have the markers
@Bisaloo
Remove unnecessary escape_markers() function
7af34be
@Bisaloo
Do not include blank cells
6f0850b
@Bisaloo Bisaloo merged commit 77ae014 into main Apr 5, 2023
@Bisaloo Bisaloo deleted the performance branch April 5, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance
1 participant
@Bisaloo