Disable interaction with players while Dragon is alive. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for this, but maybe this is too specific? Can I change it maybe to disallow clicking players when you are holding out a bow? |
ViralTaco
reviewed
Sep 3, 2019
| @@ -49,7 +49,7 @@ private void removeEntities(List<Entity> list) { | |||
| if (!SkyblockAddons.getInstance().getConfigValues().isDisabled(Feature.DISABLE_PROFILE_VIEW_IF_DRAGON_ALIVE)) { | |||
| Minecraft mc = Minecraft.getMinecraft(); | |||
| for (Entity elist : mc.theWorld.loadedEntityList) { | |||
| if (elist instanceof EntityEnderman) { | |||
| if (elist instanceof EntityDragon) { | |||
| double coreX = -670; | |||
There was a problem hiding this comment.
Shouldn't this be final?
Edit: I mean the doubles… Also it probably should be -670.0 but that's a minor detail.
There was a problem hiding this comment.
I was testing with Endermans (Zealots) and forgot to change it back to Ender Dragon, the doubles should be fine though.
ViralTaco
reviewed
Sep 3, 2019
src/main/java/codes/biscuit/skyblockaddons/mixins/MixinEntityRenderer.java
Outdated
Show resolved
Hide resolved
Way better idea than mine, didn't think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened an issue asking for this a few hours ago, ended up doing it myself with my non-existent knowledge of Java and coding in general.
Didn't hide the players because it's counterproductive.