Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fixes and cleanup #7

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

rpunnett-bf
Copy link
Contributor

@rpunnett-bf rpunnett-bf commented Sep 22, 2022

Details

  • Created removeBadPathChars in utils.aws to clean any characters that would prevent a file from being written to the operating system
    • To fix a bug where an error occurred when the Caller.UserID contained illegal characters, such as :
  • Created BuildAWSPath in utils.aws, which calls removeBadPathChars , and is called from each aws module to set m.AWSProfile by cleaning then concatenating the Caller.Account and Caller.UserID, returning a string
  • Modified all Command based functions in cli.aws to:
    • Load the config once with AWSConfigFileLoader, then pass that value to each client created in the command
    • Limit additional STS calls by running AWSWhoami once after PreRun and passing it where needed.
  • Fixed a bug in aws.instances.printInstancesUserDataAttributesOnly where, when reporting User Data from instances, a file was being written when no User Data was present; now gives standard notice no data was found
  • Minor cleanups of code to homogenize

@sethsec-bf sethsec-bf self-assigned this Sep 23, 2022
@sethsec-bf
Copy link
Contributor

This is an amazing PR @rpunnett-bf, thank you!

@sethsec-bf sethsec-bf merged commit 16fcbc2 into BishopFox:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants