Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Neptune Support #74

Merged
merged 7 commits into from Feb 27, 2024

Conversation

enzowritescode
Copy link
Contributor

  • Added .idea to .gitignore for Intellij IDEs such as GoLand
  • Added Neptune to databases scan
  • Updated list of supported databases in CLI output
  • reworked code in aws/databases.go to minimize repeated code
  • Got rid of redundant parenthesis that was supported by GoLand
  • Fixed typo in aws/sdk/rds_mocks.go

@sethsec-bf sethsec-bf self-assigned this Feb 2, 2024
enzowritescode and others added 2 commits February 19, 2024 13:05
…t grabs Neptune and DocsDB clusters, we don't need to run those api calls. (they all return the same data). Also added back port info and added role info to the RDS clusters in -o wide mode
@sethsec-bf
Copy link
Member

Hey @enzowritescode. Can you give this updated code a look and see if still returns the desired results for you? Because the Neptune and DocsDB service describe-clusters commands are just a mirror of the RDS command, i changed the RDS check a bit to just get the cluster info for all three types, and then i just correct the service based on the engine. Let me know if i missed anything.

@sethsec-bf sethsec-bf merged commit f415f99 into BishopFox:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants