Fix the inability to move windows between screens

src/kwinscript/controller/index.ts

@@ -77,6 +77,12 @@ export interface Controller {
    */
   onWindowResizeStart(window: EngineWindow): void;
 
+  /**
+   * React to window changing screens
+   * @param window the window whose screen has changed
+   */
+  onWindowScreenChanged(window: EngineWindow): void;
+
   /**
    * React to window resize operation end. The window
    * resize operation ends, when the users drops
@@ -336,7 +342,11 @@ export class ControllerImpl implements Controller {
 
   public onWindowGeometryChanged(window: EngineWindow): void {
     this.log.log(["onWindowGeometryChanged", { window }]);
-    this.engine.enforceSize(window);
+  }
+
+  public onWindowScreenChanged(_window: EngineWindow): void {
+    //TODO only arrange the surface the window came from and went to
+    this.engine.arrange();
   }
 
   // NOTE: accepts `null` to simplify caller. This event is a catch-all hack

src/kwinscript/driver/index.ts

@@ -362,9 +362,9 @@ export class DriverImpl implements Driver {
       }
     });
 
-    this.connect(client.screenChanged, () =>
-      this.controller.onWindowChanged(window, `screen=${client.screen}`)
-    );
+    this.connect(client.screenChanged, () => {
+      this.controller.onWindowScreenChanged(window);
+    });
 
     this.connect(client.activitiesChanged, () =>
       this.controller.onWindowChanged(

src/kwinscript/engine/index.ts

@@ -86,15 +86,6 @@ export interface Engine {
    */
   resizeWindow(window: EngineWindow, dir: CompassDirection, step: Step): void;
 
-  /**
-   * Re-apply window geometry, computed by layout algorithm.
-   *
-   * Sometimes applications move or resize windows without user intervention,
-   * which is straight against the purpose of tiling WM. This operation
-   * move/resize such windows back to where/how they should be.
-   */
-  enforceSize(window: EngineWindow): void;
-
   /**
    * @returns the layout we have on the surface of the active window
    */
@@ -386,12 +377,6 @@ export class EngineImpl implements Engine {
     return this.controller.currentWindow;
   }
 
-  public enforceSize(window: EngineWindow): void {
-    if (window.tiled && !window.actualGeometry.equals(window.geometry)) {
-      window.commit();
-    }
-  }
-
   public manage(window: EngineWindow): void {
     if (!window.shouldIgnore) {
       /* engine#arrange will update the state when required. */