Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-14 Failed to read input stream #17

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

anderseknert
Copy link
Contributor

Fix bug in directory creation logic and split the nested try-catch statements into separate ones for more granular error messages.

Fixes #14

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #17 into master will increase coverage by 5.65%.
The diff coverage is 52.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     76.25%   81.91%   +5.65%     
- Complexity       49       60      +11     
============================================
  Files            10       10              
  Lines           278      282       +4     
  Branches         15       15              
============================================
+ Hits            212      231      +19     
+ Misses           59       44      -15     
  Partials          7        7              
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/bisnode/opa/TestRegoTask.java 78.72% <52.38%> (-2.68%) 7.00 <0.00> (ø)
.../opa/configuration/DefaultOpaPluginConvention.java 100.00% <0.00%> (+47.05%) 9.00% <0.00%> (+5.00%)
...ode/opa/configuration/DefaultOpaConfiguration.java 100.00% <0.00%> (+75.00%) 7.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4341b...4c8bd02. Read the comment docs.

@anderseknert anderseknert force-pushed the GH-14-Failed-to-read-input-stream branch from ec32094 to be7c28e Compare June 10, 2020 14:08
Fix bug in directory creation logic and split the nested try-catch statements into separate ones for more granular error messages.

Fixes #14
@anderseknert anderseknert force-pushed the GH-14-Failed-to-read-input-stream branch from be7c28e to 4c8bd02 Compare June 14, 2020 11:28
@anderseknert anderseknert merged commit 2df1203 into master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to read input stream
1 participant