Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write opa coverage report to the project's build directory #67

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

vierbergenlars
Copy link
Contributor

Instead of writing to the project rootDir, which is the top-level directory of the whole build, write to the buildDir, which is the subproject-specific directory for build artifacts.

In a multi-project Gradle project, I expect the reports to be written to the build directory for that subproject, and not in a directory inside the root project.

Using buildDir also honors any customisations that Gradle users have made to their project's buildDir.

Instead of writing to the project `rootDir`, which is the top-level directory of the whole build, write to the `buildDir`, which is the subproject-specific directory for build artifacts.

In a multi-project Gradle project, I expect the reports to be written to the build directory for that subproject, and not in a directory inside the root project.

Using `buildDir` also honors any customisations that Gradle users have made to their project's `buildDir`.
Copy link
Contributor

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anderseknert
Copy link
Contributor

Oh, I apparently don't have merging powers in this repo anymore 😅 I'll see if I can ping someone who does.

@lukasz-kaminski
Copy link
Member

Hi, thanks for the contribution! We'll release it soon.

@lukasz-kaminski lukasz-kaminski merged commit 0051725 into Bisnode:master Jan 26, 2022
@vierbergenlars vierbergenlars deleted the patch-1 branch February 1, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants