Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize gas fee #401

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Optimize gas fee #401

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c05676d
optimize gas fee
Mar 16, 2023
64c9e17
remove unchecked iterator increments
Mar 18, 2023
080a995
formatting my code
Mar 18, 2023
b0e159d
format my code
Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions contracts/src/v0.1/VRFCoordinator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,10 @@ contract VRFCoordinator is
revert NoSuchProvingKey(kh);
}
delete s_provingKeys[kh];
for (uint256 i = 0; i < s_provingKeyHashes.length; i++) {
uint256 provingKeyHashesLength = s_provingKeyHashes.length;
for (uint256 i; i < provingKeyHashesLength; i++) {
if (s_provingKeyHashes[i] == kh) {
bytes32 last = s_provingKeyHashes[s_provingKeyHashes.length - 1];
bytes32 last = s_provingKeyHashes[provingKeyHashesLength - 1];
// Copy last element and overwrite kh to be deleted with it
s_provingKeyHashes[i] = last;
s_provingKeyHashes.pop();
Expand Down