forked from aws-samples/aws-secrets-manager-rotation-lambdas
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the InfluxDB Single and Multi-user Secret Rotation Lambdas. #1
Merged
forestmvey
merged 4 commits into
influxdb-secret-rotation-lambdas
from
dev-influxdb-secret-rotation-lambdas
Apr 17, 2024
Merged
Adding the InfluxDB Single and Multi-user Secret Rotation Lambdas. #1
forestmvey
merged 4 commits into
influxdb-secret-rotation-lambdas
from
dev-influxdb-secret-rotation-lambdas
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
trevorbonas
reviewed
Apr 17, 2024
Signed-off-by: forestmvey <forestv@bitquilltech.com>
trevorbonas
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some small things to fix.
SecretsManagerInfluxDBMultiUserRotation/integration/aws_integration_test_client.py
Outdated
Show resolved
Hide resolved
SecretsManagerInfluxDBSingleUserRotation/integration/aws_integration_test_client.py
Outdated
Show resolved
Hide resolved
Signed-off-by: forestmvey <forestv@bitquilltech.com>
trevorbonas
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The InfluxDB Single and Multi-user Secret Rotation Lambdas enables the automatic rotation for authorizations with
Timestream for InfluxDB
. The Multi-user rotation lambda uses an admin authenticated session to rotate another set of user or token credentials. The Single-user rotation lambda rotates their own authenticated session, and require the appropriate permissions to perform the rotation. The Multi-user rotation lambda can be used to rotate any credentials with any permissions.Validations:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.