Java: Publish JAR to local Maven repository #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanl-bq
requested review from
GumpacG,
aaron-congo,
Yury-Fridlyand,
acarbonetto,
tjzhang-BQ and
SanHalacogluImproving
jonathanl-bq
commented
Apr 29, 2024
| * Native Interface). | ||
| * | ||
| * @see <a | ||
| * href="http://adamheinrich.com/blog/2012/how-to-load-native-jni-library-from-jar">http://adamheinrich.com/blog/2012/how-to-load-native-jni-library-from-jar</a> |
There was a problem hiding this comment.
Most of the contents of this file are taken from here. The code is MIT licensed, which is why I preferred this solution over the NativeLibLoader solution that was copy pasted from stack overflow.
jonathanl-bq
commented
Apr 29, 2024
| publishing { | ||
| publications { | ||
| mavenJava(MavenPublication) { | ||
| groupId = 'software.amazon' |
There was a problem hiding this comment.
I set this based on what they use for the Amazon SDK in the Polyglot dependencies. It might not be correct.
acarbonetto
approved these changes
May 1, 2024
| mavenJava(MavenPublication) { | ||
| groupId = 'software.amazon' | ||
| artifactId = 'glide' | ||
| version = "0.0.1" |
There was a problem hiding this comment.
keep this for now, but I think we want sync the version number with node/python before we publish
| } | ||
| } | ||
| repositories { | ||
| mavenLocal() |
Yury-Fridlyand
approved these changes
May 2, 2024
jonathanl-bq
merged commit 382ef2b
into
java/integ_lotjonat_publish_jar
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change publishes the Java glide client JAR to the local Maven repository. The built JAR file contains the Rust native lib code. This is not portable, so we will need to ensure that we build one JAR per supported platform.