Java: Add Logger #265
Merged
Java: Add Logger #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanl-bq
requested review from
GumpacG,
aaron-congo,
Yury-Fridlyand,
acarbonetto and
tjzhang-BQ
|
We have few logging TODOs left in client code - can you complete them in scope of this PR? |
GumpacG
approved these changes
May 10, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
CI hung. You need to rerun spotless though. |
Yury-Fridlyand
approved these changes
May 14, 2024
java/client/src/test/java/glide/connection/ConnectionWithGlideMockTests.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 15, 2024
java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/connectors/handlers/ReadHandler.java
Outdated
Show resolved
Hide resolved
| public final class Logger { | ||
| // TODO: consider lazy loading the glide_rs library | ||
| static { | ||
| System.loadLibrary("glide_rs"); |
There was a problem hiding this comment.
can you move the static loading to the ffi.resolvers package?
Example: https://github.com/Bit-Quill/glide-for-redis/blob/c998a2c366b524270a82c1148bfa477f7ab3318c/java/client/src/main/java/glide/ffi/resolvers/SocketListenerResolver.java
There was a problem hiding this comment.
I think you can remove this static loader - I don't think it doesn't anything here.
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto
approved these changes
May 17, 2024
| public final class Logger { | ||
| // TODO: consider lazy loading the glide_rs library | ||
| static { | ||
| System.loadLibrary("glide_rs"); |
There was a problem hiding this comment.
I think you can remove this static loader - I don't think it doesn't anything here.
acarbonetto
reviewed
May 17, 2024
Yury-Fridlyand
approved these changes
May 17, 2024
Yury-Fridlyand
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Logger implementation here is based on the Python client's implementation, with some relatively small Java/JNI specific changes.