New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update murmurhash package #894
Conversation
Change the lastguest/murmurhash package from "^2.0.0" to "^2.1"
Can this be merged? i really need php 8 support. |
Merge this please and create a release @Bit-Wasp @rubensayshi @afk11 |
@@ -1,5 +1,5 @@ | |||
{ | |||
"name": "bitwasp/bitcoin", | |||
"name": "n3omaster/bitcoin-php", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidental name change
@@ -23,10 +23,10 @@ | |||
} | |||
}, | |||
"require": { | |||
"php-64bit": ">=7.0", | |||
"php-64bit": "^7.0|^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also add 0.8
to the .travis.yml
versions list?
Has Php 8 support been added yet? |
1 similar comment
Has Php 8 support been added yet? |
No, seems like this package is inactive. Perhaps we should create a fork and continue maintaining? @ndirpaya |
@ExpDev07 Someone has forked it already, and it works! https://github.com/n3omaster/bitcoin-php |
Be more compatible with PHP 8