Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/UPDATE] Setting permissions and commands #603

Merged
merged 3 commits into from Mar 17, 2018

Conversation

oviniciusfeitosa
Copy link
Contributor

Changing lendingbot.service permission and setting the command sudo systemctl daemon-reload before enable lendingbot.service

Description

TESTING STAGE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read CONTRIBUTING.md
  • I fully understand Github Flow.
  • My code adheres to the code style of this project.
  • I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
  • I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
  • I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

Changing `lendingbot.service` permission and setting the command `sudo systemctl daemon-reload` before enable `lendingbot.service`
@ghost ghost added the Queued label Jan 2, 2018
@utdrmac
Copy link
Contributor

utdrmac commented Jan 2, 2018

Are you sure these changes are not distro/OS specific? I didn't have to chmod 644 or do a daemon-reload on my OS to get things to work. My distro is ReadyNAS/FreeBSD. On which distro did you test this?

@oviniciusfeitosa
Copy link
Contributor Author

In my case I had to follow these steps to work correctly using a raspberry pi.

The operating system I used for the test was the RASPBIAN STRETCH LITE

Worked perfectly!

@utdrmac
Copy link
Contributor

utdrmac commented Jan 2, 2018

Could you test your changes on other OSes? Your "fix" may break others.

@oviniciusfeitosa
Copy link
Contributor Author

What if the text is specific for raspberry pi users who use Raspbian? I find it impractical to test all possible operating systems ...

@rnevet
Copy link
Collaborator

rnevet commented Jan 2, 2018

If it's a specific setup solution then I suggest adding it in the documentation.

Copy link
Member

@Evanito Evanito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the late response.

@@ -66,10 +66,25 @@ To download the bot you can either:
WantedBy=multi-user.target

Credit to GitHub user utdrmac.


The permission on the unit file needs to be set to 644 :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only necessary on some OSs, please rephrase this to say "may" need to be set...
Very useful Troubleshooting tip! :)

@ghost ghost assigned rnevet Mar 17, 2018
@ghost ghost added Testing Phase and removed Queued labels Mar 17, 2018
@rnevet rnevet merged commit ce42446 into BitBotFactory:master Mar 17, 2018
@ghost ghost removed the Testing Phase label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants