Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[naming things] Suggestion: rename passphrase to BIP39 passphrase #801

Closed
SCBuergel opened this issue Mar 22, 2020 · 3 comments
Closed

[naming things] Suggestion: rename passphrase to BIP39 passphrase #801

SCBuergel opened this issue Mar 22, 2020 · 3 comments
Assignees
Labels
enhancement Improvement of existing feature; small compared to a feature good-first-issue Good for newcomers wontfix This will not be worked on

Comments

@SCBuergel
Copy link

It is great that Bitbox2 supports mnemonics + passphrase. Unfortunately, not all providers are so clear about the distinction between password (for device) and BIP39 passphrase from which the HD seed is generated.

It would help users if you could be maximal explicit by renaming the optional passphrase under the Expert settings to optional BIP39 passphrase (and change in instructions and website accordingly).

@benma
Copy link
Contributor

benma commented Mar 23, 2020

This also affects the mnemonic seed. A few months ago we renamed BIP39 mnemonic to mnemonic seed, and mnemonic passphrase to optional passphrase. The idea was that the term BIP39 is very technical and meaningless to newcomers, so we opted to use more standard words.

Would it help if we added a entries to the blue guide on the right where BIP39 would be mentioned explicitly? So expert users coming from different HW vendors could look for it.

@x1ddos x1ddos added the enhancement Improvement of existing feature; small compared to a feature label Aug 11, 2020
@My1
Copy link

My1 commented Sep 16, 2020

Would it help if we added a entries to the blue guide on the right where BIP39 would be mentioned explicitly?

that would help. espeially since outside of the bitbox the phrases used here arent that often used, so this can get chaotic fast when people using different wallets help each other.

@x1ddos x1ddos added the good-first-issue Good for newcomers label Apr 12, 2021
@thisconnect thisconnect self-assigned this Sep 15, 2021
@benma benma added the wontfix This will not be worked on label May 29, 2023
@benma
Copy link
Contributor

benma commented May 29, 2023

We've been using "optional passphrase" and "recovery words" for some years now and there does not seem to be any confusion among newcomers and users migrating from other wallets.

@benma benma closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature; small compared to a feature good-first-issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants