frontend simpler coinbalance

[thisconnect]

Coin balance needs a list of coinCodes and some way to display the
coin name.

Before this change it first constructed a map that contains accounts
per coin, as the name of the coin is only included in IAccount
interface.

Using a dedicated utils function to derive the coin name from coin
codes simplifies CoinBalance component.

Also cleanup and type keys of various maps in 2nd commit

Before the key was just of type string, but in these cases
we have proper types.

[strmci]

tested, nice

I would name testnet coins so these names are consistent with the names in backend.go
tbtc: Bitcoin Testnet
tltc: Litecoin Testnet
goeth: Ethereum Goerli
sepeth: Ethereum Sepolia

It will be nice to have it sorted as Bitcoin, Litecoin, and Ethereum...

Are all the other coins in the getCoinName needed? Can't we just return coinCode?

[thisconnect]

@strmci I address your feedback, it should use correct names i.e. "Bitcoin Testnet" for tbtc etc.

I think the other tokens would be needed but the backend doesn't return those for total coin balance I think. So I removed those for now. But probably the backend should return all coins and tokens for the total coin balance.

also it sorts now correctly... but it sorts in the frontend. Other places we keep the sort as it is coming from backend (accounts), but here we don't use accounts anymore (and we shouldn't imo).

If that all is good as is, I'd like to also get feedback from @Beerosagos

[thisconnect]

actully on master it shows tokens.. need to figure out how I broke it...

[strmci]

But probably the backend should return all coins and tokens for the total coin balance.

I think it should return coins only from active accounts as it currently does.

tested on both testnet and mainnet, LGTM

[thisconnect]

yes is does, I somehow thought backend doesn't show tokens totals.

[thisconnect]

this is not correct as type CoinCode does not include the tokens. Type casting is not ideal here.

[thisconnect]

added another commit that properly types CoinOrTokenCode ... but now it's huge.
But I could remove this type cast here. 😅

[thisconnect]

IMO we could also drop the 3rd crazy typescript commit and I open a separate PR, let me know

opened a new PR #2717 so that this can be merged.

[thisconnect]

rebased

[thisconnect]

@strmci ack to merge? 😇

[strmci]

@strmci ack to merge? 😇

tACK

[Beerosagos]

The code looks good to me, but I feel like we should rely on the backend sorting if possible to avoid duplicates.
Also what about we add the coin name inside the coin total balance response?

CCing @benma as he also had an opinion about leaving sorting in the backend, iirc

[strmci]

Also what about we add the coin name inside the coin total balance response?

I also checked that option. Do you mean to add it to the FormattedAmount type, or?

[Beerosagos]

Also what about we add the coin name inside the coin total balance response?

I also checked that option. Do you mean to add it to the FormattedAmount type, or?

I was thinking about enclosing the formattedAmount inside a CoinFormattedAmount object, together with the coin name, and returning it inside the map produced by this function. This way we don't propagate the change in every place where we use the FormattedAmount.
But your idea could be good too, I'm not sure about which one is the better approach, didn't think much about it yet

[thisconnect]

I think we should re-consider doing both (visual-coin-order-sort & coin-name) in the frontend.

Coin name lookup by coinCode is very simple, see this PR. Not sure the backend needs to know about human readable coinName at all.

Sorting in the frontend seems to me is much easier than in the backend. Is the sorting in the backend used for anything else that showing this order in the frontend?

Note: Some api's return items in an array [item, item, ...] in order. Other API's return an objects / map {}. Objects are not iterable and don't have any information about how the items are ordered. We could add an index property to each item in the object of course as a workaround.. but then why do this in the backend?

[thisconnect]

I think there is some good typescript improvements in this PR. I'll try to make a separate smaller one.

Backend should keep controlling sort and provide coin names, this should come from backends for example if we ever had a different UI.

[thisconnect]

closing in favor of only typscript improvements #2733