ci: fix ci after repo move to bitboxswiss #2716
Merged
+857
−808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
reviewed
May 16, 2024
thisconnect
force-pushed
the
ci-with-bitboxswiss
branch
4 times, most recently
from
59adb11
to
8f0c1c9
Compare
|
I believe this is unrelated, and a random fail that sometimes occurs.. I'll run pipeline one more time. |
|
@benma ci passed, please let me know if I should just squash all commits or if there is anything else that needs to be changed. |
benma
requested changes
May 16, 2024
|
I think appveyor ci isn't running at all, @benma could you login and see if we need to activate appveyor for bitboxswiss ? |
I changed the repo url in appveyor, can you push again to see if it will be triggered? Amending commit with no change or a small commit msg change. |
thisconnect
force-pushed
the
ci-with-bitboxswiss
branch
from
dc1a058
to
73f6b99
Compare
The GitHub org changed to github.com/BitBoxSwiss
- update ghcr url to use bitboxswiss, using lowercase bitboxswiss for ghcr
- backend: change all imports to bitboxswiss
- update appveyor yaml to use new org bitboxswiss
vendor: bitbox02-api-go
go get github.com/BitBoxSwiss/bitbox02-api-go@b22740e514bcce2d01c92588d5890e9af8e4fbcb
go mod tidy
go mod vendor
vendor: block-client-go
go get github.com/BitBoxSwiss/block-client-go@0d604acd65198ec3d3768d4691f95243aff71eab
go mod tidy
go mod vendor
|
ci passed with appveyor, squashing now.... |
thisconnect
force-pushed
the
ci-with-bitboxswiss
branch
from
73f6b99
to
0dd9660
Compare
Beerosagos
added a commit
to Beerosagos/bitbox-wallet-app
that referenced
this pull request
May 23, 2024
testAccountsByKeystore test was occasionally failing the check on the number of loaded accounts for each keystore (see BitBoxSwiss#2716 (comment)) This fix excludes the `HiddenBecauseUnused` accounts from the check and should fix the issue.
NicolaLS
pushed a commit
to NicolaLS/bitbox-wallet-app
that referenced
this pull request
Jun 4, 2024
testAccountsByKeystore test was occasionally failing the check on the number of loaded accounts for each keystore (see BitBoxSwiss#2716 (comment)) This fix excludes the `HiddenBecauseUnused` accounts from the check and should fix the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo changed to github.com/BitBoxSwiss