Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made changes in the "TheProgrammingClubBetaComponent.js" file, and added a new file "style.css" to add hover states to the buttons and links #10

Closed
wants to merge 8 commits into from

Conversation

abhineetpandey10
Copy link

No description provided.

@abhineetpandey10 abhineetpandey10 changed the title edited index.html and App.js. made changes in the "TheProgrammingClubBetaComponent.js" file, and added a new file "style.css" to make the webpage responsive Jan 8, 2021
@abhineetpandey10
Copy link
Author

abhineetpandey10 commented Jan 8, 2021

2021-01-08.13-42-55.mp4

The webpage UI now contains hover states for the buttons and links.

import React from "react"
import ReactDOM from "react-dom"
import TheProgrammingClubFinalComponent from ".React Components/TheProgrammingClubBetaComponent.js"
function App()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave a blank line between imports and function

@Samy-33
Copy link
Member

Samy-33 commented Jan 8, 2021

@abhineetpandey10, how is it responsive when there is a horizontal scroll bar?

@abhineetpandey10 abhineetpandey10 changed the title made changes in the "TheProgrammingClubBetaComponent.js" file, and added a new file "style.css" to make the webpage responsive made changes in the "TheProgrammingClubBetaComponent.js" file, and added a new file "style.css" to add hover states to the buttons and links Jan 8, 2021
@abhineetpandey10
Copy link
Author

I had misinterpreted "Responsive". Have edited the comment accordingly, and have applied the requested changes in the "App.js" file.

@Samy-33
Copy link
Member

Samy-33 commented Jan 8, 2021

I had misinterpreted "Responsive". Have edited the comment accordingly, and have applied the requested changes in the "App.js" file.

No problem. Please read below about how to write good commit messages:
https://www.freecodecamp.org/news/writing-good-commit-messages-a-practical-guide/

@MananJethwani
Copy link
Member

this PR needs to be closed sorry @abhineetpandey10 aksh has already made most of the component and that will me merged soon and that includes correct fonts responsive site and mobile view as well extremly sorry for wasting your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants