Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#321: Fix report/meeting event missing #349

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

cddjr
Copy link
Contributor

@cddjr cddjr commented Apr 14, 2022

In some cases, 'PlayerControl_ReportDeadBody' will not be triggered.
So I changed to hook the 'PlayerControl_CoStartMeeting' function to make sure the event is logged.

fixes #321

In some cases, 'PlayerControl_ReportDeadBody' will not be triggered. So I changed to hook the 'PlayerControl_CoStartMeeting' function to make sure the event is logged
@cddjr

This comment was marked as resolved.

@v0idp
Copy link
Member

v0idp commented Apr 15, 2022

According to your graph it will only trigger when you're host, what about games where you are not the host ?

@cddjr
Copy link
Contributor Author

cddjr commented Apr 15, 2022

According to your graph it will only trigger when you're host, what about games where you are not the host ?

Players will receive RpcCalls::StartMeeting from host.

@v0idp
Copy link
Member

v0idp commented Apr 15, 2022

According to your graph it will only trigger when you're host, what about games where you are not the host ?

Players will receive RpcCalls::StartMeeting from host.

you mean the CoStartMeeting you hook too?

@cddjr
Copy link
Contributor Author

cddjr commented Apr 15, 2022

Yes, just hook it.

According to your graph it will only trigger when you're host, what about games where you are not the host ?

Players will receive RpcCalls::StartMeeting from host.

you mean the CoStartMeeting you hook too?

Yes, it’s always triggered by meetings. So we don’t need to hook CmdReportDeadBody and ReportDeadBody.

@v0idp v0idp merged commit 6eb2c11 into BitCrackers:main Apr 15, 2022
@cddjr cddjr deleted the fix_321_event_missing branch April 15, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some events are not registered/registered improperly
2 participants