Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2022.8.24 #414

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Update to 2022.8.24 #414

merged 3 commits into from
Aug 24, 2022

Conversation

cddjr
Copy link
Contributor

@cddjr cddjr commented Aug 24, 2022

Based on v2022.8.24e(2267)

AAAAAXfda-zz
AAAAAXfda-zz approved these changes Aug 24, 2022
View reviewed changes
Copy link

@AAAAAXfda-zz AAAAAXfda-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AAAAAXfda-zz
Copy link

I'll get back to you, I'm currently compiling and going to be testing the PR.

AAAAAXfda-zz
AAAAAXfda-zz approved these changes Aug 24, 2022
View reviewed changes
Copy link

@AAAAAXfda-zz AAAAAXfda-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cddjr @ChaseBrand @v0idp @OsOmE1 @kotae4 @std-nullptr
Upon further review, it's safe to say that cddjr's patch is working flawlessly. I'll be merging this to the main branch in a moment.
Among_Us_5Lc4eDtyRv

@ChaseBrand
Copy link
Member

Pretty sure merging is blocked until a core team member reviews it. If no one beats me to it, I'll do it after work.

@OsOmE1
Copy link
Member

OsOmE1 commented Aug 24, 2022

@cddjr @ChaseBrand @v0idp @OsOmE1 @kotae4 @std-nullptr Upon further review, it's safe to say that cddjr's patch is working flawlessly. I'll be merging this to the main branch in a moment. Among_Us_5Lc4eDtyRv

Okay yes pls merge into main 👍

@OsOmE1
Copy link
Member

OsOmE1 commented Aug 24, 2022

On a more serious note looks good and works for what I tested thanks again @cddjr for the great work on the update.

@OsOmE1 OsOmE1 closed this Aug 24, 2022
@OsOmE1 OsOmE1 reopened this Aug 24, 2022
@OsOmE1 OsOmE1 merged commit e745731 into BitCrackers:main Aug 24, 2022
@cddjr cddjr deleted the 2022.8.24e branch December 23, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OsOmE1 OsOmE1 OsOmE1 approved these changes

@AAAAAXfda-zz AAAAAXfda-zz AAAAAXfda-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cddjr @AAAAAXfda-zz @ChaseBrand @OsOmE1