Skip to content

Commit

Permalink
Merge pull request #32 from EFinley/patch-1
Browse files Browse the repository at this point in the history
Replace arbitrary int with named constant
  • Loading branch information
Bobrovsky committed Nov 21, 2016
2 parents cbf4363 + 12a9731 commit 8a694f7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
Expand Up @@ -29,8 +29,9 @@ namespace BitMiracle.LibTiff.Samples
{
TiffFieldInfo[] tiffFieldInfo =
{
new TiffFieldInfo(TIFFTAG_GDAL_METADATA, -1, -1, TiffType.ASCII,
FieldBit.Custom, true, false, "GDALMetadata"),
new TiffFieldInfo(TIFFTAG_GDAL_METADATA, TiffFieldInfo.Variable,
TiffFieldInfo.Variable, TiffType.ASCII, FieldBit.Custom,
true, false, "GDALMetadata"),
};

tif.MergeFieldInfo(tiffFieldInfo, tiffFieldInfo.Length);
Expand Down Expand Up @@ -88,8 +89,9 @@ Namespace BitMiracle.LibTiff.Samples
Private Shared m_parentExtender As Tiff.TiffExtendProc

Public Shared Sub TagExtender(tif As Tiff)
Dim tiffFieldInfo As TiffFieldInfo() = {New TiffFieldInfo(TIFFTAG_GDAL_METADATA, -1, -1, TiffType.ASCII, FieldBit.[Custom], True, _
False, "GDALMetadata")}
Dim tiffFieldInfo As TiffFieldInfo() = {New TiffFieldInfo(TIFFTAG_GDAL_METADATA, _
TiffFieldInfo.Variable, TiffFieldInfo.Variable, TiffType.ASCII, FieldBit.[Custom], _
True, False, "GDALMetadata")}

tif.MergeFieldInfo(tiffFieldInfo, tiffFieldInfo.Length)

Expand Down
Expand Up @@ -34,7 +34,8 @@ namespace BitMiracle.LibTiff.Samples
{
TiffFieldInfo[] tiffFieldInfo =
{
new TiffFieldInfo(TIFFTAG_ASCIITAG, -1, -1, TiffType.ASCII, FieldBit.Custom, true, false, "MyTag"),
new TiffFieldInfo(TIFFTAG_ASCIITAG, TiffFieldInfo.Variable, TiffFieldInfo.Variable,
TiffType.ASCII, FieldBit.Custom, true, false, "MyTag"),
new TiffFieldInfo(TIFFTAG_SHORTTAG, 2, 2, TiffType.SHORT, FieldBit.Custom, false, true, "ShortTag"),
new TiffFieldInfo(TIFFTAG_LONGTAG, 2, 2, TiffType.LONG, FieldBit.Custom, false, true, "LongTag"),
new TiffFieldInfo(TIFFTAG_RATIONALTAG, 2, 2, TiffType.RATIONAL, FieldBit.Custom, false, true, "RationalTag"),
Expand Down Expand Up @@ -182,8 +183,9 @@ Namespace BitMiracle.LibTiff.Samples
Private Shared m_parentExtender As Tiff.TiffExtendProc

Public Shared Sub TagExtender(ByVal tif As Tiff)
Dim tiffFieldInfo As TiffFieldInfo() = {New TiffFieldInfo(TIFFTAG_ASCIITAG, -1, -1, TiffType.ASCII, FieldBit.[Custom], True, _
False, "MyTag"), New TiffFieldInfo(TIFFTAG_SHORTTAG, 2, 2, TiffType.[SHORT], FieldBit.[Custom], False, _
Dim tiffFieldInfo As TiffFieldInfo() = {New TiffFieldInfo(TIFFTAG_ASCIITAG, TiffFieldInfo.Variable, _
TiffFieldInfo.Variable, TiffType.ASCII, FieldBit.[Custom], True, False, "MyTag"), _
New TiffFieldInfo(TIFFTAG_SHORTTAG, 2, 2, TiffType.[SHORT], FieldBit.[Custom], False, _
True, "ShortTag"), New TiffFieldInfo(TIFFTAG_LONGTAG, 2, 2, TiffType.[LONG], FieldBit.[Custom], False, _
True, "LongTag"), New TiffFieldInfo(TIFFTAG_RATIONALTAG, 2, 2, TiffType.RATIONAL, FieldBit.[Custom], False, _
True, "RationalTag"), New TiffFieldInfo(TIFFTAG_FLOATTAG, 2, 2, TiffType.FLOAT, FieldBit.[Custom], False, _
Expand Down

0 comments on commit 8a694f7

Please sign in to comment.