Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a diff command to compare 2 memory dumps #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliverde8
Copy link

Hi,

First thanks for this tool, it really is awesome.

I found myself comparing 2 dump on a few occasions and trying to see where I am leaking. So I thought it would be a nice feature to have in the analyzer.

Regards

@oliverde8
Copy link
Author

Hi,

And ideas why the test didn't pass? It looks like a timeout to me.

@BitOne
Copy link
Owner

BitOne commented Feb 8, 2018

Hey, thanks a lot @oliverde8 !

And sorry for the delay before the answer.
I will have a look at the test failure, I think it's related to some changes in PHP 7.2, not from your code.

I think that your diff is a great feature, very useful in the hunting memory leak process.

But could you put the diff generation part in a dedicated class, like a SummaryDiffer ? This class would take two summaries and generate a diff.

This would make testing much easier than having everything in the command. And by the way, if you could make the associated Spec, that would be awesome ;)

Thank you!

@oliverde8
Copy link
Author

Hi,

Np, thanks for the response.

I hadn't seen the Spec's, my bad. I will update it, just not sure when I will find time.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants