Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for building on windows #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyberemissary
Copy link

This allows to build on windows in accordance to php build guide: https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2

DISCLAIMER: Personally only tested on PHP 7.2, but this should work for all other version that this extension supports

@BitOne
Copy link
Owner

BitOne commented Jun 25, 2019

Thanks @cyberemissary for this work. My main problem is that I don't have access to a Windows environment. So I cannot maintain and support this configuration.
Moreover, I cannot make sure that new development will not break this code.
But Travis seems to have Windows support now: https://blog.travis-ci.com/2018-10-11-windows-early-release

Can you provide a changed in .travis.yml file with the right commands to build the extension and run the phpt tests? I have no idea what to do to compile it on Windows.

Thanks in advance !

Copy link
Owner

@BitOne BitOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add configuration for running tests on Travis.

@cyberemissary
Copy link
Author

Although it compiles, it doesn't actually work on windows, Does not return any memory data.

I'll try go debug this, but don't know when I will have time. Once I figure it out i'll add the travis configs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants