Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

The 5% margin call fee is gone in dvs/0.9.0 ? #1499

Closed
abitmore opened this issue Apr 11, 2015 · 4 comments
Closed

The 5% margin call fee is gone in dvs/0.9.0 ? #1499

abitmore opened this issue Apr 11, 2015 · 4 comments
Milestone

Comments

@abitmore
Copy link
Member

  • BM said the 5% fee will be eliminated in this post https://bitsharestalk.org/index.php/topic,13782.0/all.html, because an operation will be implemented to cover the short with collateral and bypass the fee.
  • The operation is implemented in this commit 211c5e1, and named update_call_price. At the same commit the 5% fee is gone.
  • The update_call_price operation is renamed to update_cover in this commit c48646f.
  • The update_cover operation is removed in this commit: 445e22d

So the only result is, the 5% fee gone. Is it expected?

@vikramrajkumar vikramrajkumar added this to the dvs/0.9.1 milestone Apr 13, 2015
@vikramrajkumar
Copy link
Contributor

@abitmore Good catch and good work tracing the commit history.

Given BM's explanation in the linked thread and in particular this segment:

In reality the 5% fee merely served to create a variable amount of additional collateral depending upon the risk tolerance of each individual shorter. Considering we are raising the min collateral requirement from 1.5 to 2x the added benefit of the 5% fee is insignificant. The fear of a short squeeze and being forced to buy at up to 10% above the feed if there are not enough orders at the feed means there is still plenty of incentive to avoid forced buying.

And in the interest of simplicity and avoiding the additional development and testing that would be required for further changes, we will leave things as they are with the 5% fee now removed.

@xeroc
Copy link
Member

xeroc commented May 4, 2015

Has this made it's way into bts/0.9.0 tag?

@abitmore
Copy link
Member Author

abitmore commented May 4, 2015

Sure.

@xeroc
Copy link
Member

xeroc commented May 4, 2015

If so it was not properly communicated in the forums IMHO

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants