Latest revison doesnt build

[alexxy]

Starting from 2c5d6ff (?? may be because of merge) bitshares_toolkit doesnt build

[ 73%] Building CXX object libraries/wallet/CMakeFiles/bts_wallet.dir/wallet.cpp.o
/home/alexxy/Src/bitshares_toolkit/libraries/wallet/wallet.cpp: In member function 'void bts::wallet::wallet::set_receive_address_memo(const bts::blockchain::address&, const string&)':
/home/alexxy/Src/bitshares_toolkit/libraries/wallet/wallet.cpp:640:74: error: invalid initialization of non-const reference of type 'std::__detail::_Node_iterator<bts::wallet::receive_address, true, true>&' from an rvalue of type 'std::unordered_setbts::wallet::receive_address::iterator {aka std::__detail::_Node_iterator<bts::wallet::receive_address, true, true>}'
auto& found = my->_data.receive_addresses.find(receive_address(addr));
^
libraries/wallet/CMakeFiles/bts_wallet.dir/build.make:57: recipe for target 'libraries/wallet/CMakeFiles/bts_wallet.dir/wallet.cpp.o' failed
make[2]: *** [libraries/wallet/CMakeFiles/bts_wallet.dir/wallet.cpp.o] Error 1
CMakeFiles/Makefile2:350: recipe for target 'libraries/wallet/CMakeFiles/bts_wallet.dir/all' failed
make[1]: *** [libraries/wallet/CMakeFiles/bts_wallet.dir/all] Error 2

[nmushegian]

fixed now? open another if no

[alexxy]

It builds, but old bug returns

1238056ms th_a main ] bad_cast
Invalid cast from type '6' to Object
{"type":6}
th_a variant.cpp:498 get_object
unable to load /home/alexxy/.bitsharesxt/default_wallet.dat
{"wal":"/home/alexxy/.bitsharesxt/default_wallet.dat"}
th_a wallet.cpp:442 open main.cpp:157

so it efffectively cannot run wallet

[vikramrajkumar]

Error returned for me also. Deleting the chain folder and the .bitsharesxt folder and starting over got it working again for me. I believe the wallet format has changed with the last couple commits.

We should eventually have some mechanism to version and upgrade wallet files, as this will happen in real life I'm sure.

[alexxy]

Doesnt work for me. It cannot start.

[alexxy]

However recreating wallet works. But its not a solution

[vikramrajkumar]

Please clarify. It now works after deleting the wallet? Or it only works on the first wallet creation and subsequent runs still crash?

[alexxy]

It works as expected. but seems like its not a solution to delete and recreate wallet on every codebase upgrade

[dnotestein]

It's likely the format for storing the wallet will change entirely, in which case any method we use now for versioning would be also likely be discarded. Best just to consider this an artifact of early development for now. We'll definitely use a more robust method for versioning once we're closer to a real release.