Skip to content

Commit

Permalink
fix AppImage deterministic build
Browse files Browse the repository at this point in the history
When building python dependencies with `pip install --no-binary :all:...`, we run into a bug caused by a cyclic dependency with `tomli==1.2.1` and `flit_core==3.2.0` while building dependencies of setuptools_scm.
Apparently, it works with `pip >= 0.21` according to pypa/flit#451 (comment)
  • Loading branch information
PiRK committed Nov 18, 2021
1 parent 8b55ef8 commit 1c30e40
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions contrib/build-linux/appimage/_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ python='appdir_python'

info "Installing pip"
"$python" -m ensurepip
# we need a pip newer than 21.0, because of https://github.com/takluyver/flit/issues/451#issuecomment-941075197
"$python" -m pip install pip==21.3.1


info "Preparing electrum-locale"
Expand Down

0 comments on commit 1c30e40

Please sign in to comment.